Skip to content

v1.41.0

Choose a tag to compare

View all tags
@hk9890 hk9890 released this 10 Oct 12:27
· 175 commits to master since this release
v1.41.0
6ba626a
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode.

The review of a PR is now its own skill, /worktree-flow:worktree-review. An agent can start it, and a project doc names this one command as its review step.

One command for the full review of a PR

/worktree-flow:worktree-review [pr-number] runs the two reviews on a PR and pushes what they fix:

  1. It checks the PR: open, not from a fork, its head in this checkout, the tree clean.
  2. It runs each gate of the project on the PR's head. A review reads a change that works, so the run stops where a gate is red.
  3. It runs the rules review (project-review:project-review-change --fix), then the code review (code-review xhigh --fix). After each review that fixed something, it runs the gates, repeats the drives, commits, and pushes to the PR's head branch.
  4. It writes the Review line into the PR body, with the head commit that was reviewed.

With no argument, it takes the PR that the current branch was pushed to. On a head that the Review line names already, the run only reports.

Before this release the two reviews were step 7 of /worktree-flow:worktree-ship, which only the user can start. A project doc that wanted this review had to name each review with its level and flag. worktree-ship now invokes the new skill at step 7, and the example CHANGE-WORKFLOW.md of the doc standard names the one command.

Where the project-review plugin is not installed, the rules review is reported as skipped, never as passed. A later run with the plugin installed runs the rules review that is missing.

Changed behavior worth knowing

  • The push names its target. The fixes go to the PR's head branch with git push <remote> HEAD:<headRefName>. Where the remote rejects the push, the run stops and keeps the commit local.
  • No push to a fork. The review stops for a PR from a fork.
  • A stopped review is reported as such. Where the review stops before it records its result, worktree-ship reports the PR as not reviewed, with the reason, and does not name the merge as the next step.
  • The Review line has a new owner. worktree-review writes it, and brings the Gate and Driven lines up to date where it ran them again. The PR body template of worktree-ship no longer holds that line.
  • Project docs. A CHANGE-WORKFLOW.md that names code-review xhigh --fix or project-review-change --fix as its review step can name /worktree-flow:worktree-review <pr> in their place.

Full Changelog: v1.40.0...v1.41.0

Assets 2
Loading