fix: use absolute paths in --allowedTools for sensitive file editing (Refs: beans-huwr)#166
Merged
Conversation
… editing (Refs: beans-huwr) - The previous fix used relative glob patterns (e.g. `Edit(.claude/**)`) which never matched because Claude Code's Edit/Write tools use absolute file paths - Now constructs patterns using session.WorkDir (e.g. `Edit(/path/.claude/**)`) - Each pattern gets its own --allowedTools flag to avoid variadic arg ambiguity
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.claude/rules/*andCLAUDE.mdfiles, despite the fix in fix: allow agent sessions to edit Claude config files in act mode (Refs: beans-huwr) #164--allowedToolspatterns used relative globs (e.g.Edit(.claude/**)) but Claude Code's Edit/Write tools operate on absolute file paths, so the patterns never matchedsession.WorkDir(e.g.Edit(/path/to/workdir/.claude/**)) and pass each with its own--allowedToolsflagTest plan
mise buildand spawn an agent in act mode via Beans UI.claude/rules/*.mdfile — should succeed without permission promptsmise testpasses