add app:theme dark/light switch#4
Merged
Merged
Conversation
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds an app-wide UI theme setting
app:theme(dark|light, defaultdark), exposed as a View → Theme menu toggle.How
app:themeenum setting, wired the same way asapp:tabbar.data-themeon<body>from the setting and live-switches through the config event pipeline (the same pathterm:themeuses), so no restart is needed.Scope
Infrastructure only — no color overrides.
[data-theme="light"]has no CSS rules yet, so selecting Light currently inherits the existing dark palette. This isolates the switching pipeline so it can be verified on its own before any palette work.Verification
View → Theme → Light flips
data-themeon<body>live (no restart) and persists tosettings.json.