Skip to content

fix(ci): lazy-load installer so mcp/help work without cli deps#73

Merged
hoainho merged 1 commit into
mainfrom
fix/release-ci-2
Jul 11, 2026
Merged

fix(ci): lazy-load installer so mcp/help work without cli deps#73
hoainho merged 1 commit into
mainfrom
fix/release-ci-2

Conversation

@hoainho

@hoainho hoainho commented Jul 11, 2026

Copy link
Copy Markdown
Owner

Follow-up to #72. The release test step still failed: cli.js statically imported install.js, which imports the cli-only decompress dep. CI installs only root deps (cli/ isn't a workspace), so that eager import failed for every command — including mcp --help — → non-zero exit → npm test failed.

install.js is now imported lazily inside the installer path only; mcp/--help load nothing beyond picocolors + node builtins. Verified with cli/node_modules removed: mcp --help exit 0, mcp-server test 3/3, full suite 455+1skip.

🤖 Generated with Claude Code

…i deps

cli.js statically imported install.js, which imports the cli-only 'decompress' dep. In CI only root deps are installed (cli/ is not a workspace), so that eager import failed for EVERY command incl. 'mcp --help' -> non-zero exit -> release test step failed. install.js is now imported lazily inside the installer path only; the mcp + --help paths load nothing beyond picocolors + node builtins. Verified with cli/node_modules removed: mcp --help exit 0, mcp-server test 3/3.
@hoainho hoainho merged commit f6abc8e into main Jul 11, 2026
2 checks passed

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the CLI entry point cli/bin/cli.js to lazily load the installer module (../src/install.js) via a new asynchronous loadInstaller function. This prevents eager importing of the decompress dependency, which was causing crashes in environments where only root dependencies are present (such as CI) when running other subcommands or the help menu. There are no review comments, and I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant