Conversation
Need to rethink the name matching now that the name is the key, and you can't access it by iterating over everything. Maybe make the key a "safe name" where you strip all the diacritics and slashes and stuff.
but we are back to Sagu Wildling not working
…maps There are probably more performance improvements with reading the JSON directly into the HashMap and storing the deduplicated HashMap instead of reading the same JSON over and over. But that will come later.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hopefully no changes on the user side, other than much faster legality and price look ups. Loading the database still takes a while.