Conversation
Need to correctly identify database type when the file is found, right now decklist file is treated as a Scryfall database and deserializing fails.
Next, check for $0.00 when finding minimum price and ignore.
…ports sorting by all currency options
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The program used to use a large database file from Scryfall to find the cheapest card prices. Loading that database on startup and sorting down to the cheapest price for each card on every startup took a while. Now the program creates a shorter JSON file with just the info for the cheapest printing of each card and uses that until the age limit is exceeded and is much faster on startup.