Fixed GraphQL hard-coded resource name on updates #289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmcnr-hx
approved these changes
Jun 1, 2017
Contributor
pmcnr-hx
left a comment
pmcnr-hx
left a comment
There was a problem hiding this comment.
Thank you for the contribution @maxschmeling. I'm going to merge as is, since it fixes an obvious problem. Like you say the tests aren't trivial so we'll try to improve the test coverage in a future PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #285
I haven't made any test changes here yet because the only way I see to do that well is with pretty significant test changes. Do you have any thoughts on the best thing to do for tests?