Feat/dbml connector/support check constraints#766
Merged
huydo862003 merged 30 commits intomasterfrom Oct 28, 2025
Merged
Conversation
huydo862003
force-pushed
the
feat/dbml-connector/support-check-constraints
branch
11 times, most recently
from
fea1498 to
bdee349
Compare
huydo862003
changed the base branch from
feat/dbml-parse/support-check-constraint
to
master
huydo862003
force-pushed
the
feat/dbml-connector/support-check-constraints
branch
3 times, most recently
from
60451fa to
525d56a
Compare
huydo862003
force-pushed
the
feat/dbml-connector/support-check-constraints
branch
from
e3ebbf3 to
48759bd
Compare
huydo862003
added
the
PR: New Feature 🚀
huydo862003
changed the base branch from
master
to
fix/change-constraint-to-check
huydo862003
commented
Oct 28, 2025
| "updated_at" "timestamp on update CURRENT_TIMESTAMP" [default: `CURRENT_TIMESTAMP`] | ||
|
|
||
| Checks { | ||
| `(`price` > 0) and (`price` < 1000000)` [name: 'products_chk_1'] |
Contributor
Author
There was a problem hiding this comment.
Please note that we currently do not escape ` inside function expression. Mysql always quote columns in backticks, so this is currently malformed DBML.
Collaborator
There was a problem hiding this comment.
Should add this related doc into this connector code as a comment em. You can also write some short notes for better understanding: https://www.notion.so/holistics/TDD-72-Database-CHECK-constraint-in-DBML-28bf89dc7e49801fa8d3fb9cf25ca8de#292f89dc7e498001bbfce3d92f74cdd4
huyphung1602
approved these changes
Oct 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Issue
(issue link here)
Lasting Changes (Technical)
(please list down: code changes/things that have wide-effect; new libraries/functions added that can be used by others; examples below)
class EmailValidatorto validate email address' validity)Tenant#is_trial?check)Checklist
Please check directly on the box once each of these are done