Skip to content

Setup lint#776

Merged
huydo862003 merged 27 commits intomasterfrom
fix-lint-issues
Nov 17, 2025
Merged

Setup lint#776
huydo862003 merged 27 commits intomasterfrom
fix-lint-issues

Conversation

@huydo862003
Copy link
Copy Markdown
Contributor

@huydo862003 huydo862003 commented Nov 4, 2025

Summary

  • Bump eslint to latest.

  • Update eslint config formats to eslint.config.ts.

  • Fix all lint errors.

  • Setup CI to check for lint errors.

  • Add npm scripts to lint.

  • Rename dbml-cli/test to tests for consistency, fix dbml-cli's jest to only runs *.spec.js, *.test.js (and other js extensions) test files.

  • Setup import aliases in @dbml/parse

  • NO RUNTIME BEHAVIOR CHANGE! All lint issues were resolved using eslint --fix so it is unlikely to break.

  • What to review:

    • Check for all eslint.config.ts.
    • Check the CI lint workflow.
    • Check the package bumps.

Issue

(issue link here)

Lasting Changes (Technical)

(please list down: code changes/things that have wide-effect; new libraries/functions added that can be used by others; examples below)

  • (Added class EmailValidator to validate email address' validity)
  • (Added Tenant#is_trial? check)

Checklist

Please check directly on the box once each of these are done

  • Documentation (if necessary)
  • Tests (integration test/unit test)
  • Integration Tests Passed
  • Code Review

Copy link
Copy Markdown
Member

@xuantho573 xuantho573 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈

@huydo862003 huydo862003 merged commit 769bb03 into master Nov 17, 2025
3 of 4 checks passed
@huydo862003 huydo862003 deleted the fix-lint-issues branch November 17, 2025 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants