Skip to content

Oracle connector#785

Merged
huydo862003 merged 39 commits intomasterfrom
feat/oracle-connector
Dec 3, 2025
Merged

Oracle connector#785
huydo862003 merged 39 commits intomasterfrom
feat/oracle-connector

Conversation

@huydo862003
Copy link
Copy Markdown
Contributor

@huydo862003 huydo862003 commented Nov 27, 2025

Summary

  • [@dbml/connector] Support Oracle connector.
  • [@dbml/connector] Move each connector to its respective folder.
  • [@dbml/core] Fix a bug in Oracle importer where quoted data types are quoted 2 times. For example:
    CREATE TABLE "gold_users" (
    "birthday" "string COLLATE Latin1_General_CS_AS"
    );

would be translated to:

Table "gold_users" {
"birthday" ""string COLLATE Latin1_General_CS_AS"" // --> double quoted
}

Implementation details:

Issue

(issue link here)

Lasting Changes (Technical)

(please list down: code changes/things that have wide-effect; new libraries/functions added that can be used by others; examples below)

  • (Added class EmailValidator to validate email address' validity)
  • (Added Tenant#is_trial? check)

Checklist

Please check directly on the box once each of these are done

  • Documentation (if necessary)
  • Lint checks
  • Tests (integration test/unit test)
  • Integration Tests Passed
  • Code Review

@huydo862003 huydo862003 force-pushed the feat/oracle-connector branch from 4f5832e to b362380 Compare November 27, 2025 03:58
@huydo862003 huydo862003 force-pushed the feat/oracle-connector branch 4 times, most recently from b970ea0 to d5c49c8 Compare November 27, 2025 10:50
@huydo862003 huydo862003 force-pushed the feat/oracle-connector branch 2 times, most recently from 70a7053 to 5b210b6 Compare November 27, 2025 11:35
@huydo862003 huydo862003 force-pushed the feat/oracle-connector branch from c4c9a3c to 32c1a73 Compare November 30, 2025 11:30
@huydo862003 huydo862003 force-pushed the feat/oracle-connector branch from 2b04f9d to 08e1cab Compare November 30, 2025 13:07
@huydo862003 huydo862003 force-pushed the feat/oracle-connector branch from f1d71bb to da286e6 Compare November 30, 2025 15:00
Comment thread packages/dbml-connector/src/connectors/oracle/index.ts
Comment thread packages/dbml-connector/src/connectors/oracle/index.ts Outdated
Comment thread packages/dbml-connector/src/connectors/oracle/tables.ts
Comment thread packages/dbml-connector/src/connectors/oracle/tables.ts
Comment thread packages/dbml-connector/src/connectors/oracle/tables.ts
Comment thread packages/dbml-connector/src/connectors/oracle/constraints.ts Outdated
Comment thread packages/dbml-cli/src/cli/index.js Outdated
Comment thread packages/dbml-cli/__tests__/db2dbml/oracle/expect-out-files/schema.dbml Outdated
Comment thread packages/dbml-cli/__tests__/db2dbml/oracle/schema.sql Outdated
@huydo862003 huydo862003 force-pushed the feat/oracle-connector branch from 2b4cdd4 to 01655fb Compare December 2, 2025 09:44
@huydo862003 huydo862003 force-pushed the feat/oracle-connector branch from 01655fb to d362f5c Compare December 2, 2025 09:45
@huydo862003 huydo862003 force-pushed the feat/oracle-connector branch 3 times, most recently from d637ecc to e5783b4 Compare December 2, 2025 12:03
@huydo862003 huydo862003 force-pushed the feat/oracle-connector branch from e5783b4 to ecea545 Compare December 2, 2025 12:28
Copy link
Copy Markdown
Contributor

@huyleminh01 huyleminh01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pr looks good to me for now
Please help trigger the unit test action again to test the flaky case if exists nha. (can trigger 1 time) since we met the flaky test with ordinal position in connector before

@huydo862003 huydo862003 merged commit 8729a30 into master Dec 3, 2025
6 checks passed
@huydo862003 huydo862003 deleted the feat/oracle-connector branch December 3, 2025 09:11
@huydo862003 huydo862003 added the PR: New Feature 🚀 A type of pull request used for changelog categories label Dec 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: New Feature 🚀 A type of pull request used for changelog categories

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants