Oracle connector#785
Merged
huydo862003 merged 39 commits intomasterfrom Dec 3, 2025
Merged
Conversation
4f5832e to
b362380
Compare
b970ea0 to
d5c49c8
Compare
70a7053 to
5b210b6
Compare
c4c9a3c to
32c1a73
Compare
2b04f9d to
08e1cab
Compare
f1d71bb to
da286e6
Compare
huyleminh01
reviewed
Dec 2, 2025
2b4cdd4 to
01655fb
Compare
01655fb to
d362f5c
Compare
d637ecc to
e5783b4
Compare
e5783b4 to
ecea545
Compare
huyleminh01
approved these changes
Dec 3, 2025
Contributor
huyleminh01
left a comment
There was a problem hiding this comment.
The pr looks good to me for now
Please help trigger the unit test action again to test the flaky case if exists nha. (can trigger 1 time) since we met the flaky test with ordinal position in connector before
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
would be translated to:
Implementation details:
Issue
(issue link here)
Lasting Changes (Technical)
(please list down: code changes/things that have wide-effect; new libraries/functions added that can be used by others; examples below)
class EmailValidatorto validate email address' validity)Tenant#is_trial?check)Checklist
Please check directly on the box once each of these are done