chore: remove "type": "module" from @dbml/core#830
Merged
huydo862003 merged 1 commit intomasterfrom Feb 25, 2026
Merged
Conversation
Coverage ReportCommit: a3caa29 Overall Coverage
Package Coverage
|
| File | Lines | Statements | Functions | Branches |
|---|---|---|---|---|
src/connectors/bigquery/index.ts |
0.00% | 0.00% | 0.00% | 0.00% |
src/utils/credential-loader.ts |
0.00% | 0.00% | 0.00% | 0.00% |
src/utils/helpers.ts |
0.00% | 0.00% | 0.00% | 0.00% |
src/connectors/snowflake/index.ts |
10.56% | 10.31% | 0.00% | 0.00% |
src/utils/parseSchema.ts |
46.15% | 42.85% | 28.57% | 27.27% |
src/connectors/connector.ts |
66.66% | 66.66% | 100.00% | 57.14% |
src/connectors/oracle/tables.ts |
71.25% | 67.39% | 100.00% | 56.96% |
src/connectors/oracle/index.ts |
80.00% | 80.76% | 100.00% | 25.00% |
src/connectors/oracle/utils.ts |
85.71% | 85.71% | 100.00% | 71.42% |
@dbml/dbml-parse
39 file(s) below 80% coverage
| File | Lines | Statements | Functions | Branches |
|---|---|---|---|---|
src/compiler/queries/container/scope.ts |
0.00% | 0.00% | 0.00% | 100.00% |
src/services/diagnostics/provider.ts |
0.00% | 0.00% | 0.00% | 0.00% |
src/compiler/queries/parse.ts |
50.00% | 50.00% | 50.00% | 100.00% |
src/core/interpreter/elementInterpreter/project.ts |
51.42% | 51.42% | 100.00% | 45.45% |
src/core/interpreter/records/utils/data/sqlTypes.ts |
56.25% | 58.82% | 75.00% | 46.55% |
src/core/analyzer/symbol/utils.ts |
56.52% | 56.52% | 100.00% | 50.00% |
src/core/analyzer/binder/elementBinder/note.ts |
62.50% | 64.70% | 83.33% | 50.00% |
src/compiler/queries/utils.ts |
62.63% | 63.82% | 88.88% | 46.15% |
src/core/interpreter/records/utils/data/values.ts |
65.13% | 57.14% | 72.72% | 50.37% |
src/compiler/queries/token.ts |
66.66% | 66.66% | 66.66% | 100.00% |
src/core/analyzer/binder/elementBinder/enum.ts |
66.66% | 68.42% | 100.00% | 50.00% |
src/core/analyzer/validator/elementValidators/note.ts |
72.54% | 70.90% | 76.92% | 68.75% |
src/core/analyzer/validator/elementValidators/indexes.ts |
73.33% | 74.07% | 90.90% | 59.61% |
src/core/analyzer/analyzer.ts |
75.00% | 66.66% | 60.00% | 100.00% |
src/core/analyzer/symbol/symbolIndex.ts |
76.92% | 77.50% | 92.85% | 50.00% |
src/core/analyzer/utils.ts |
77.77% | 76.36% | 88.88% | 75.00% |
src/core/analyzer/binder/elementBinder/project.ts |
77.77% | 78.94% | 100.00% | 50.00% |
src/core/analyzer/validator/elementValidators/checks.ts |
77.77% | 79.31% | 93.75% | 71.87% |
src/core/analyzer/validator/elementValidators/records.ts |
78.08% | 78.66% | 93.75% | 74.19% |
src/core/analyzer/validator/elementValidators/project.ts |
78.12% | 78.78% | 100.00% | 56.25% |
src/core/utils.ts |
78.57% | 77.41% | 80.00% | 60.71% |
src/core/analyzer/binder/elementBinder/ref.ts |
78.78% | 80.00% | 90.90% | 75.00% |
src/core/analyzer/binder/elementBinder/indexes.ts |
79.06% | 77.77% | 90.90% | 68.18% |
src/core/analyzer/binder/elementBinder/tableGroup.ts |
80.00% | 80.64% | 100.00% | 50.00% |
src/services/suggestions/utils.ts |
80.39% | 75.00% | 92.85% | 68.51% |
src/core/interpreter/records/utils/constraints/pk.ts |
82.00% | 80.00% | 92.30% | 54.54% |
src/core/analyzer/binder/elementBinder/records.ts |
82.79% | 83.33% | 93.75% | 71.42% |
src/compiler/queries/container/token.ts |
83.33% | 85.71% | 100.00% | 75.00% |
src/core/analyzer/validator/elementValidators/tablePartial.ts |
83.43% | 80.72% | 87.23% | 64.28% |
src/core/analyzer/validator/elementValidators/enum.ts |
83.72% | 82.22% | 84.21% | 78.26% |
src/core/analyzer/binder/elementBinder/tablePartial.ts |
86.00% | 86.53% | 100.00% | 69.23% |
src/core/parser/parser.ts |
86.85% | 87.00% | 100.00% | 78.94% |
src/services/suggestions/recordRowSnippet.ts |
88.67% | 84.61% | 100.00% | 78.00% |
__tests__/utils/compiler.ts |
88.88% | 89.85% | 100.00% | 68.13% |
src/compiler/queries/symbol.ts |
91.30% | 92.00% | 100.00% | 78.57% |
src/core/interpreter/elementInterpreter/sticky_note.ts |
95.00% | 95.23% | 100.00% | 66.66% |
src/core/interpreter/records/utils/constraints/unique.ts |
96.15% | 93.93% | 100.00% | 66.66% |
src/core/analyzer/symbol/symbolTable.ts |
100.00% | 100.00% | 100.00% | 75.00% |
src/services/definition/provider.ts |
100.00% | 100.00% | 100.00% | 75.00% |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove
"type": "module"from@dbml/corepackage.jsonto fix CJS consumer type resolution.Details:
moduleResolution: "node16"or"nodenext", like Runsql) fail to import this package with the following error:Context:
.mjsand.cjscode files, but.d.tstype declaration files.Root cause:
.d.tsfiles using the nearestpackage.json's"type"field."type": "module"set, ourindex.d.tsis treated as ESM.-> TypeScript refuses to let CJS consumers
requirethe type declaration files, even though the runtime entry point (index.cjs) is perfectly valid CJS.Solution: Remove
"type": "module"frompackage.json. This makes.d.tsdefault to CJS, which works for both consumers:.d.tsas CJS ->requireworksimportworksThis is safe because our runtime files already use explicit extensions (
.mjs/.cjs), so Node resolves them correctly regardless of the"type"field.Issue
(issue link here)
Lasting Changes (Technical)
(please list down: code changes/things that have wide-effect; new libraries/functions added that can be used by others; examples below)
class EmailValidatorto validate email address' validity)Tenant#is_trial?check)Checklist
Please check directly on the box once each of these are done