Skip to content

misc(dbml-parse): upgrade lodash-es to v4.18.1#885

Merged
huyleminh01 merged 4 commits intomasterfrom
misc/bump-lodash-lodash-es
Apr 28, 2026
Merged

misc(dbml-parse): upgrade lodash-es to v4.18.1#885
huyleminh01 merged 4 commits intomasterfrom
misc/bump-lodash-lodash-es

Conversation

@huyleminh01
Copy link
Copy Markdown
Contributor

@huyleminh01 huyleminh01 commented Apr 28, 2026

Summary

  • Bump lodash-es in dbml/parse, dbml/core, dbml/connector to v4.18.1 to fix vulnerable issues
  • Bump lodash in dbml/core to v4.18.1 to fix vulnerable issues

Issue

(issue link here)

Lasting Changes (Technical)

(please list down: code changes/things that have wide-effect; new libraries/functions added that can be used by others; examples below)

  • (Added class EmailValidator to validate email address' validity)
  • (Added Tenant#is_trial? check)

Checklist

Please check directly on the box once each of these are done

  • Documentation (if necessary)
  • Lint Checks Passed
  • Unit Tests Passed
  • Coverage Tests Passed
  • Integration Tests Passed
  • Code Review

@huyleminh01 huyleminh01 marked this pull request as ready for review April 28, 2026 08:25
@github-actions
Copy link
Copy Markdown

Coverage Report

Commit: 48d059d

Overall Coverage

Metric Coverage
Lines ✅ 84.12% (5991/7122)
Statements ✅ 83.14% (6393/7689)
Functions ✅ 87.82% (1363/1552)
Branches ⚠️ 75.06% (3477/4632)

Package Coverage

Package Lines Statements Functions Branches
@dbml/dbml-cli ✅ 100.00% ✅ 100.00% ✅ 100.00% ✅ 100.00%
@dbml/dbml-connector ⚠️ 64.62% ⚠️ 64.36% ⚠️ 59.53% ⚠️ 59.09%
@dbml/dbml-core N/A N/A N/A N/A
@dbml/dbml-parse ✅ 87.10% ✅ 85.98% ✅ 91.36% ⚠️ 77.14%

⚠️ Coverage Warnings

The following packages have coverage below 80%:

  • @dbml/dbml-connector: 64.62% line coverage

Files with Coverage Below 80%

@dbml/dbml-connector

9 file(s) below 80% coverage
File Lines Statements Functions Branches
src/connectors/bigquery/index.ts 0.00% 0.00% 0.00% 0.00%
src/utils/credential-loader.ts 0.00% 0.00% 0.00% 0.00%
src/utils/helpers.ts 0.00% 0.00% 0.00% 0.00%
src/connectors/snowflake/index.ts 10.56% 10.31% 0.00% 0.00%
src/utils/parseSchema.ts 46.15% 42.85% 28.57% 27.27%
src/connectors/connector.ts 66.66% 66.66% 100.00% 57.14%
src/connectors/oracle/tables.ts 71.25% 67.39% 100.00% 56.96%
src/connectors/oracle/index.ts 80.00% 80.76% 100.00% 25.00%
src/connectors/oracle/utils.ts 85.71% 85.71% 100.00% 71.42%

@dbml/dbml-parse

44 file(s) below 80% coverage
File Lines Statements Functions Branches
src/compiler/queries/container/scope.ts 0.00% 0.00% 0.00% 100.00%
src/core/types/internable.ts 0.00% 0.00% 0.00% 0.00%
src/services/diagnostics/provider.ts 0.00% 0.00% 0.00% 0.00%
src/core/types/symbol/utils.ts 6.89% 6.89% 66.66% 0.00%
src/core/utils/span.ts 14.28% 14.28% 33.33% 16.66%
src/core/types/filepath.ts 25.00% 23.33% 41.17% 8.33%
src/core/types/report.ts 50.00% 44.44% 58.33% 42.85%
src/core/interpreter/elementInterpreter/project.ts 51.42% 51.42% 100.00% 45.45%
src/core/interpreter/records/utils/data/sqlTypes.ts 56.25% 58.82% 75.00% 46.55%
src/core/analyzer/binder/elementBinder/enum.ts 61.11% 63.15% 83.33% 50.00%
src/core/analyzer/binder/elementBinder/note.ts 62.50% 64.70% 83.33% 50.00%
src/compiler/queries/utils.ts 64.83% 65.95% 88.88% 47.43%
src/core/interpreter/records/utils/data/values.ts 65.13% 57.14% 72.72% 50.71%
src/compiler/queries/legacy/parse.ts 66.66% 66.66% 66.66% 100.00%
src/compiler/queries/legacy/token.ts 66.66% 66.66% 66.66% 100.00%
src/core/analyzer/validator/elementValidators/indexes.ts 71.42% 72.28% 90.90% 57.40%
src/core/analyzer/validator/elementValidators/note.ts 74.54% 72.88% 76.92% 72.22%
src/core/analyzer/analyzer.ts 75.00% 66.66% 60.00% 100.00%
src/core/analyzer/validator/elementValidators/project.ts 76.47% 77.14% 100.00% 55.55%
src/core/analyzer/utils.ts 76.69% 75.23% 87.50% 72.52%
src/core/analyzer/validator/elementValidators/checks.ts 76.78% 78.33% 93.75% 70.58%
src/core/analyzer/validator/elementValidators/records.ts 77.02% 77.63% 93.75% 73.43%
src/core/analyzer/binder/elementBinder/project.ts 77.77% 78.94% 100.00% 50.00%
src/core/types/symbol/symbolIndex.ts 78.26% 78.72% 93.75% 52.38%
src/core/analyzer/binder/elementBinder/ref.ts 78.78% 80.00% 90.90% 75.00%
src/core/analyzer/binder/elementBinder/diagramView.ts 78.94% 79.26% 84.00% 63.63%
src/core/analyzer/binder/elementBinder/indexes.ts 79.54% 78.26% 90.90% 70.83%
src/core/analyzer/binder/elementBinder/tableGroup.ts 80.00% 80.64% 100.00% 50.00%
src/core/interpreter/records/utils/constraints/pk.ts 82.00% 81.53% 92.30% 59.09%
src/services/suggestions/utils.ts 82.35% 76.78% 92.85% 68.96%
src/core/analyzer/binder/elementBinder/records.ts 82.60% 83.15% 93.75% 68.00%
src/core/analyzer/validator/elementValidators/tablePartial.ts 82.75% 80.41% 87.23% 63.75%
src/compiler/queries/container/token.ts 83.33% 85.71% 100.00% 75.00%
src/core/analyzer/validator/elementValidators/diagramView.ts 84.69% 80.95% 85.00% 72.00%
src/core/analyzer/binder/elementBinder/tablePartial.ts 86.00% 86.53% 100.00% 69.23%
src/core/parser/parser.ts 87.12% 87.27% 100.00% 79.62%
src/core/types/nodes.ts 88.05% 87.68% 86.11% 72.13%
src/services/suggestions/recordRowSnippet.ts 88.46% 84.37% 100.00% 78.00%
src/compiler/queries/legacy/symbol.ts 91.66% 92.00% 100.00% 78.57%
src/core/interpreter/elementInterpreter/diagramView.ts 92.55% 90.56% 90.00% 71.95%
__tests__/utils/compiler.ts 93.26% 92.95% 100.00% 69.14%
src/core/interpreter/elementInterpreter/sticky_note.ts 95.00% 95.23% 100.00% 66.66%
src/core/types/symbol/symbolTable.ts 100.00% 100.00% 100.00% 75.00%
src/services/definition/provider.ts 100.00% 100.00% 100.00% 75.00%

@huyleminh01 huyleminh01 added pkg: core PR: Dependencies Update 🤖 A type of pull request used for changelog categories pkg: connector pkg: parse labels Apr 28, 2026
@huyleminh01 huyleminh01 merged commit ec53a8e into master Apr 28, 2026
8 of 9 checks passed
@huyleminh01 huyleminh01 deleted the misc/bump-lodash-lodash-es branch April 28, 2026 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg: connector pkg: core pkg: parse PR: Dependencies Update 🤖 A type of pull request used for changelog categories

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants