Schema-qualified tables throw error in diagram view nodeReferee by huydo862003 · Pull Request #908 · holistics/dbml

huydo862003 · 2026-05-26T04:19:01Z

Summary

Any code with this:

DiagramView V {
  Tables {
    schema.table // culprit
  }
}

throws an error

can't access property "variable", e.expression is undefined

REMEMBER: always call nodeReferee(table)/nodeReferee(schema) instead of nodeReferee(schema.table).

Issue

(issue link here)

Lasting Changes (Technical)

(please list down: code changes/things that have wide-effect; new libraries/functions added that can be used by others; examples below)

(Added class EmailValidator to validate email address' validity)
(Added Tenant#is_trial? check)

Checklist

Please check directly on the box once each of these are done

github-actions · 2026-05-26T04:58:27Z

Coverage Report

Commit: 2ce82da

Overall Coverage

Metric	Coverage
Lines	✅ 84.99% (8570/10083)
Statements	✅ 82.38% (9305/11295)
Functions	✅ 87.42% (1793/2051)
Branches	⚠️ 73.61% (5574/7572)

Package Coverage

Package	Lines	Statements	Functions	Branches
@dbml/dbml-cli	✅ 100.00%	✅ 100.00%	✅ 100.00%	✅ 100.00%
@dbml/dbml-connector	⚠️ 64.62%	⚠️ 64.36%	⚠️ 59.53%	⚠️ 59.09%
@dbml/dbml-core	N/A	N/A	N/A	N/A
@dbml/dbml-parse	✅ 87.10%	✅ 84.15%	✅ 89.98%	⚠️ 74.71%

⚠️ Coverage Warnings

The following packages have coverage below 80%:

@dbml/dbml-connector: 64.62% line coverage

Files with Coverage Below 80%

@dbml/dbml-connector

9 file(s) below 80% coverage

File	Lines	Statements	Functions	Branches
`src/connectors/bigquery/index.ts`	0.00%	0.00%	0.00%	0.00%
`src/utils/credential-loader.ts`	0.00%	0.00%	0.00%	0.00%
`src/utils/helpers.ts`	0.00%	0.00%	0.00%	0.00%
`src/connectors/snowflake/index.ts`	10.56%	10.31%	0.00%	0.00%
`src/utils/parseSchema.ts`	46.15%	42.85%	28.57%	27.27%
`src/connectors/connector.ts`	66.66%	66.66%	100.00%	57.14%
`src/connectors/oracle/tables.ts`	71.25%	67.39%	100.00%	56.96%
`src/connectors/oracle/index.ts`	80.00%	80.76%	100.00%	25.00%
`src/connectors/oracle/utils.ts`	85.71%	85.71%	100.00%	71.42%

@dbml/dbml-parse

81 file(s) below 80% coverage

File	Lines	Statements	Functions	Branches
`src/compiler/queries/container/scope.ts`	0.00%	0.00%	0.00%	0.00%
`src/services/diagnostics/provider.ts`	0.00%	0.00%	0.00%	0.00%
`src/compiler/queries/pipeline/interpret.ts`	11.76%	13.51%	66.66%	41.66%
`src/services/suggestions/crossFile.ts`	19.35%	19.44%	33.33%	10.00%
`src/core/local_modules/enum/index.ts`	48.00%	46.29%	57.14%	52.63%
`src/core/global_modules/project/interpret.ts`	52.50%	46.66%	83.33%	23.07%
`src/compiler/projectLayout/layout.ts`	54.16%	53.84%	75.00%	52.63%
`src/compiler/queries/legacy/parse.ts`	61.53%	53.33%	66.66%	25.00%
`src/core/local_modules/ref/index.ts`	62.50%	61.76%	100.00%	57.14%
`src/core/types/symbol/symbols.ts`	62.54%	55.03%	59.83%	45.77%
`src/core/global_modules/records/utils/data/values.ts`	63.30%	55.71%	72.72%	49.28%
`src/core/local_modules/tableGroup/validate.ts`	64.10%	64.44%	71.42%	58.00%
`src/compiler/queries/legacy/token.ts`	66.66%	66.66%	66.66%	100.00%
`src/core/global_modules/enum/bind.ts`	66.66%	68.75%	83.33%	50.00%
`src/core/local_modules/program/index.ts`	66.66%	69.23%	75.00%	62.50%
`src/core/global_modules/note/bind.ts`	69.23%	71.42%	83.33%	50.00%
`src/core/local_modules/checks/index.ts`	69.23%	75.00%	100.00%	64.28%
`src/core/local_modules/project/index.ts`	69.23%	69.23%	100.00%	63.63%
`src/core/local_modules/note/validate.ts`	70.58%	67.56%	76.92%	62.50%
`src/core/types/report.ts`	70.83%	66.66%	83.33%	71.42%
`src/core/local_modules/tablePartial/validate.ts`	73.01%	71.83%	79.22%	57.67%
`src/compiler/queries/utils.ts`	73.10%	73.38%	90.90%	51.11%
`src/core/global_modules/project/bind.ts`	73.33%	75.00%	100.00%	50.00%
`src/core/local_modules/indexes/index.ts`	73.68%	69.35%	63.63%	64.28%
`src/core/local_modules/use/index.ts`	73.91%	75.00%	75.00%	81.25%
`src/core/local_modules/note/index.ts`	75.00%	75.86%	75.00%	72.72%
`src/core/local_modules/project/validate.ts`	75.00%	75.86%	100.00%	56.25%
`src/services/suggestions/utils/index.ts`	75.00%	75.00%	100.00%	60.71%
`src/core/parser/utils.ts`	75.30%	75.59%	100.00%	81.88%
`src/core/local_modules/records/index.ts`	75.60%	76.19%	100.00%	68.08%
`src/core/local_modules/custom/index.ts`	76.47%	76.19%	80.00%	75.00%
`src/core/global_modules/records/utils/data/sqlTypes.ts`	76.59%	80.64%	82.35%	72.22%
`src/core/local_modules/indexes/validate.ts`	76.81%	77.33%	90.90%	62.00%
`src/core/global_modules/utils.ts`	76.92%	73.80%	62.50%	62.50%
`src/core/global_modules/tableGroup/bind.ts`	79.31%	80.00%	100.00%	57.14%
`src/core/types/filepath.ts`	79.48%	78.57%	77.77%	70.37%
`src/core/global_modules/indexes/bind.ts`	80.00%	78.37%	90.00%	73.07%
`src/core/global_modules/program/utils.ts`	80.00%	80.00%	100.00%	70.00%
`src/core/local_modules/records/validate.ts`	80.00%	80.55%	93.75%	72.30%
`src/core/local_modules/checks/validate.ts`	81.25%	82.69%	93.75%	70.00%
`src/core/local_modules/diagramView/validate.ts`	81.33%	78.04%	84.21%	72.72%
`src/core/global_modules/indexes/interpret.ts`	81.39%	72.00%	100.00%	56.66%
`src/core/local_modules/tablePartial/index.ts`	81.48%	81.48%	100.00%	77.27%
`__tests__/utils/compiler.ts`	82.14%	80.10%	100.00%	58.11%
`src/core/parser/parser.ts`	82.42%	82.67%	98.41%	73.50%
`src/core/global_modules/records/bind.ts`	82.92%	83.72%	93.75%	67.30%
`src/compiler/queries/container/token.ts`	83.33%	85.71%	100.00%	75.00%
`src/core/global_modules/ref/bind.ts`	83.33%	83.87%	90.00%	75.00%
`src/core/global_modules/records/utils/constraints/pk.ts`	84.61%	81.42%	92.59%	56.52%
`src/core/local_modules/table/validate.ts`	84.87%	85.47%	90.24%	73.40%
`src/core/local_modules/enum/validate.ts`	85.24%	81.81%	81.25%	76.31%
`__tests__/utils/mocks.ts`	85.71%	86.20%	75.00%	100.00%
`src/core/global_modules/use/index.ts`	86.31%	82.11%	100.00%	77.41%
`src/core/global_modules/tablePartial/bind.ts`	86.79%	87.27%	100.00%	71.42%
`src/services/suggestions/utils/useMerger.ts`	86.95%	81.13%	100.00%	46.34%
`src/core/global_modules/tableGroup/interpret.ts`	88.09%	88.37%	100.00%	77.27%
`src/core/global_modules/tablePartial/interpret.ts`	88.29%	80.73%	84.21%	67.16%
`src/services/suggestions/recordRowSnippet.ts`	88.46%	87.09%	100.00%	73.80%
`src/compiler/queries/nodeAtPosition.ts`	88.88%	90.00%	100.00%	75.00%
`src/core/global_modules/diagramView/index.ts`	89.16%	86.23%	83.33%	78.18%
`src/compiler/index.ts`	89.74%	89.91%	75.00%	75.00%
`src/services/suggestions/provider.ts`	89.80%	85.59%	98.38%	77.41%
`src/core/global_modules/table/interpret.ts`	90.62%	84.72%	95.45%	67.70%
`src/core/global_modules/records/index.ts`	90.90%	87.15%	100.00%	79.16%
`src/core/global_modules/schema/index.ts`	92.26%	82.46%	91.66%	70.07%
`src/core/types/symbol/metadata.ts`	92.34%	78.24%	97.61%	63.15%
`src/core/utils/interpret.ts`	92.98%	89.47%	100.00%	73.13%
`src/core/global_modules/diagramView/interpret.ts`	94.54%	90.40%	92.85%	75.75%
`src/services/suggestions/use.ts`	94.68%	87.61%	100.00%	77.45%
`src/core/global_modules/tableGroup/index.ts`	94.73%	89.13%	88.88%	78.78%
`src/core/global_modules/note/interpret.ts`	95.23%	95.45%	100.00%	66.66%
`src/core/global_modules/records/interpret.ts`	95.97%	92.59%	100.00%	79.54%
`__tests__/examples/interpreter/multifile/utils.ts`	96.00%	89.65%	100.00%	62.50%
`src/compiler/queries/canonicalName.ts`	96.96%	92.10%	100.00%	76.66%
`src/core/global_modules/program/interpret.ts`	97.07%	91.45%	100.00%	70.31%
`src/core/types/errors.ts`	98.44%	98.46%	66.66%	100.00%
`src/compiler/queries/transform/renameTable.ts`	99.05%	90.47%	100.00%	78.82%
`src/core/global_modules/checks/interpret.ts`	100.00%	88.88%	100.00%	60.00%
`src/core/global_modules/program/index.ts`	100.00%	85.71%	100.00%	75.00%
`src/core/global_modules/records/utils/constraints/unique.ts`	100.00%	95.00%	100.00%	62.50%
`src/services/definition/provider.ts`	100.00%	95.23%	100.00%	71.42%

fix: namespaced tables do not work in diagram view nodeReferee

33c2117

huydo862003 added the PR: Bug Fix 🐛 A type of pull request used for changelog categories label May 26, 2026

huydo862003 added 2 commits May 26, 2026 11:28

v8.2.1-alpha.0

2132b2e

test: add another test for diagramview

054adc4

xuantho573 approved these changes May 26, 2026

View reviewed changes

chore: revert back to 8.2.0

1012961

huydo862003 merged commit ee02325 into master May 26, 2026
5 checks passed

huydo862003 deleted the hotfix/diagram-view-resolution branch May 26, 2026 04:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Schema-qualified tables throw error in diagram view nodeReferee#908

Schema-qualified tables throw error in diagram view nodeReferee#908
huydo862003 merged 4 commits into
masterfrom
hotfix/diagram-view-resolution

huydo862003 commented May 26, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented May 26, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

huydo862003 commented May 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Issue

Lasting Changes (Technical)

Checklist

Uh oh!

github-actions Bot commented May 26, 2026

Coverage Report

Overall Coverage

Package Coverage

⚠️ Coverage Warnings

Files with Coverage Below 80%

@dbml/dbml-connector

@dbml/dbml-parse

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

huydo862003 commented May 26, 2026 •

edited

Loading