-
Notifications
You must be signed in to change notification settings - Fork 19
Add Lift/Colift/SolveLinearSystemInAbCategoryOrFail #678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
94f80a0 to
7fe1516
Compare
Codecov Report
@@ Coverage Diff @@
## master #678 +/- ##
==========================================
- Coverage 69.86% 69.61% -0.25%
==========================================
Files 275 275
Lines 37375 37591 +216
==========================================
+ Hits 26111 26168 +57
- Misses 11264 11423 +159
Continue to review full report at Codecov.
|
b1cae7a to
d8afbe4
Compare
Lift/Colift/SolveLinearSystemInAbCategory now assume that a lift/colift/ solution exists.
sebastianpos
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked the changes to the Freyd package. They all look fine. As we discussed yesterday, I'll merge this PR.
Changes contained in the PR:
The first commit is preparatory (we useMerged as Allow to exclude operations from being resolved #681.DecideZeroRows/Columnsin the second commit which would cause errors in the compiler).MereExistenceOfWitnessPairForBeingCongruentToZerois added for Adelman categories.AddLiftetc.), because these are still correct: If the input is valid according to the new specification, these implementations do not returnfailin the old specification and thus everything is fine. However, I have adjusted some implementations where the tests needIsLiftableetc. (which cannot be derived fromLiftetc. anymore and thus have to be added primitively).Fixes #673.
@sebastianpos I think it would be a good idea if you could review the changes touching
FreydCategoriesForCAP. All the "new" code is copied from somewhere else (e.g. the code inIsLiftableinGradedCategoryOfRowsis copied fromCategoryOfRows), so there is no need for an in-depth review, but I think it would be good if you could check that I have copied things from the correct place (i.e. it's easy to swapLiftandColiftby accident :D).