Avoid collision with Intent message_id from FCM - #7283
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses a noisy Firebase Cloud Messaging (FCM) analytics log caused by an Intent extra key ("message_id") used by NfcSetupActivity, which conflicts with FCM’s internal expectation that message_id is a String. The fix namespaces the extra key to avoid collisions while keeping the intent payload behavior the same.
Changes:
- Replaced the
Intentextra key from"message_id"to a namespaced value ("io.homeassistant.companion.android.extra.MESSAGE_ID") to prevent FCM bundle key collisions.
jpelgrom
approved these changes
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The NFCWriteActivity was using an extra
message_idthat collide with the internals of FCM messaging analytics interface. We are not using the interface since the analytics are not enabled but it still throw a log at usThe PR change the name of the extra to be unique.