Add more triggers and conditions on the sun domain
#1394
|
As part of this roadmap opportunity, we would like to introduce various new triggers and conditions on the The list of proposed triggers and conditions (pasted from the opportunity, which will be the source of truth) follows below. Some notes:
Phases vs. moments (dawn, dusk, and twilight)These terms are easy to conflate, so to be precise about how they map to triggers and conditions here:
Deliberate naming convention deviationsThe sun domain does not fit the trigger/condition naming convention cleanly, and we are deviating on purpose:
Triggers and conditionsHigher priorityTriggers
Conditions
Lower priority (add later)Triggers
Conditions
Changelog23-6-2024
|
Replies: 5 comments 6 replies
|
Hey @nielsrowinbik ! I don't think this requires an architecture proposal here, since there is no architecture changes or changes to the entity models. EDIT: oh, is it because its a change to the |
|
Feedback from core meeting May 21st:
|
|
I personally want to see these implemented. A couple things worth revising though. I've added an appendix with the revised triggers and conditions at the end of this comment. Conditions
Triggers
Numbers
Appendix: Revised complete list of triggers and conditions with my feedback appliedRevised complete list of conditions and triggers, courtesy of ClaudeHigher priorityTriggers
Conditions
Lower priorityTriggers
Conditions
Notes
|
|
My main issue with the revised list: it enumerates every level instead of treating them as one concept with a parameter. The dawn/dusk and twilight levels are all separate entries now: I'd rather have:
Same applies to golden/blue hour, which shouldn't be eight triggers.
One naming nit: the conditions mix styles. ../Frenck Blogging my personal ramblings at frenck.dev |
|
The proposal was approved by the core architecture meeting 2026-06-18 with these remarks:
Note "consolidated version" refers to:
|
The proposal was approved by the core architecture meeting 2026-06-18 with these remarks:
Note "consolidated version" refers to: