Skip to content

Fix Tuya unsupported cameras - #136960

Merged
abmantis merged 12 commits into
home-assistant:devfrom
maghiel:tuya-camera_fix-132844
Feb 13, 2025
Merged

Fix Tuya unsupported cameras#136960
abmantis merged 12 commits into
home-assistant:devfrom
maghiel:tuya-camera_fix-132844

Conversation

@maghiel

@maghiel maghiel commented Jan 30, 2025

Copy link
Copy Markdown
Contributor

Proposed change

Fixes #132844 by adding the "dghsxj" category to cameras. Some, mostly LSC Smart Connect, devices suddenly moved from sp to dghsxj, rendering them as "unsupported". (As discovered by @Neirop)

Most Tuya cameras are in the device category "sp". About two months ago Tuya suddenly changed the category on some camera's, mostly of the LSC Smart Connect brand sold by Action stores in Europe, to "dghsxj".

It turns out "dghsxj" is a new, but still undocumented, category for "lower power consumption" cameras that Tuya moved some cameras too without any announcement whatsover. (Discoverd by @MPParsley)

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant home-assistant Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @maghiel

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant

Copy link
Copy Markdown
Contributor

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant

Copy link
Copy Markdown
Contributor

Hey there @tuya, @zlinoliver, mind taking a look at this pull request as it has been labeled with an integration (tuya) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of tuya can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign tuya Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@maghiel
maghiel marked this pull request as ready for review January 31, 2025 16:19
@maghiel

maghiel commented Jan 31, 2025

Copy link
Copy Markdown
Contributor Author

Sorry guys, my first pull request here. Accidently clicked Ready for review. Following the checklist as we speak!

@maghiel maghiel changed the title Tuya camera fix 132844 Tuya integration unsupported camera fix 132844 Jan 31, 2025
@abmantis abmantis changed the title Tuya integration unsupported camera fix 132844 Fix Tuya unsupported cameras Feb 4, 2025
@maghiel

maghiel commented Feb 6, 2025

Copy link
Copy Markdown
Contributor Author

@abmantis did I make a mistake by merging updates from dev again, seeing all the checks have to pass again?
Sorry for the inconvenience, I'm learning ;)

@abmantis

abmantis commented Feb 6, 2025

Copy link
Copy Markdown
Member

@maghiel Its ok to merge from dev from time to time or when there are conflicts to resolve.
Since this is your first contribution here, the CI does not run automatically so someone needs to trigger it. But that is fine :)

@maghiel

maghiel commented Feb 6, 2025

Copy link
Copy Markdown
Contributor Author

@maghiel Its ok to merge from dev from time to time or when there are conflicts to resolve. Since this is your first contribution here, the CI does not run automatically so someone needs to trigger it. But that is fine :)

Awesome, thanks for the explanation and help! And thanks for triggering it again ;)
My thoughtpath was something like: I should keep my pr as up-to-date as possible, but I might have been overdoing that.

@stevesinchak stevesinchak left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, ty

@maghiel

maghiel commented Feb 12, 2025

Copy link
Copy Markdown
Contributor Author

@abmantis could you? ..... :)

@abmantis
abmantis merged commit d4c5479 into home-assistant:dev Feb 13, 2025
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 14, 2025

@frenck frenck left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there, @maghiel, let's make a fully up PR to remove all this duplication.

/CC @abmantis

Comment thread homeassistant/components/tuya/select.py
Comment thread homeassistant/components/tuya/number.py
Comment thread homeassistant/components/tuya/light.py
@maghiel
maghiel deleted the tuya-camera_fix-132844 branch March 7, 2025 23:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TUYA: Tuya integration droped camera support for TY-CG6E-300W(T31+SC3336+AIW4211L by Tuya after 2412.1 (missed 0)

5 participants