Skip to content

Add an event entity to sfr_box to get call history events#166703

Draft
robin-thoni wants to merge 18 commits intohome-assistant:devfrom
robin-thoni:robin-thoni-sfrbox-voip-callhistory-1
Draft

Add an event entity to sfr_box to get call history events#166703
robin-thoni wants to merge 18 commits intohome-assistant:devfrom
robin-thoni:robin-thoni-sfrbox-voip-callhistory-1

Conversation

@robin-thoni
Copy link
Copy Markdown
Contributor

Proposed change

Add an event entity that triggers for every new call entry in the call history:

Screenshot from 2026-03-27 18-44-58 Screenshot from 2026-03-27 18-45-06

This PR sits in top of #166609. Once #166609 is merged, this one can be marked as ready to review.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies a diff between library versions and ideally a link to the changelog/release notes is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link
Copy Markdown

Hey there @epenet, mind taking a look at this pull request as it has been labeled with an integration (sfr_box) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of sfr_box can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign sfr_box Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) on the pull request.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 18 out of 18 changed files in this pull request and generated no comments.

Copilot AI review requested due to automatic review settings April 10, 2026 10:47
@robin-thoni
Copy link
Copy Markdown
Contributor Author

@epenet Do you know if there's a way to disable the need for a doc PR? Since individual entities are not documented, adding a new one, even on a new platform, should not require doc changes.

@epenet
Copy link
Copy Markdown
Contributor

epenet commented Apr 10, 2026

@epenet Do you know if there's a way to disable the need for a doc PR? Since individual entities are not documented, adding a new one, even on a new platform, should not require doc changes.

New platform => needs doc

Comment on lines 10 to +11
PLATFORMS = [Platform.BINARY_SENSOR, Platform.SENSOR]
PLATFORMS_WITH_AUTH = [*PLATFORMS, Platform.BUTTON]
PLATFORMS_WITH_AUTH = [*PLATFORMS, Platform.BUTTON, Platform.EVENT]
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that I think of it, I think it would be best if you could create a preliminary PR to drop PLATFORMS_WITH_AUTH

I remember this being discussed on Discord, and we should simply always load ALL platforms.
I didn't think of it on previous PR, but that would make things simpler

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Sorry, I did saw your message, I'm just a bit busy, will try to take care of it next week)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants