Add an event entity to sfr_box to get call history events#166703
Add an event entity to sfr_box to get call history events#166703robin-thoni wants to merge 18 commits intohome-assistant:devfrom
Conversation
|
Hey there @epenet, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
|
@epenet Do you know if there's a way to disable the need for a doc PR? Since individual entities are not documented, adding a new one, even on a new platform, should not require doc changes. |
New platform => needs doc |
| PLATFORMS = [Platform.BINARY_SENSOR, Platform.SENSOR] | ||
| PLATFORMS_WITH_AUTH = [*PLATFORMS, Platform.BUTTON] | ||
| PLATFORMS_WITH_AUTH = [*PLATFORMS, Platform.BUTTON, Platform.EVENT] |
There was a problem hiding this comment.
Now that I think of it, I think it would be best if you could create a preliminary PR to drop PLATFORMS_WITH_AUTH
I remember this being discussed on Discord, and we should simply always load ALL platforms.
I didn't think of it on previous PR, but that would make things simpler
There was a problem hiding this comment.
(Sorry, I did saw your message, I'm just a bit busy, will try to take care of it next week)
Proposed change
Add an
evententity that triggers for every new call entry in the call history:This PR sits in top of #166609. Once #166609 is merged, this one can be marked as ready to review.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: