Skip to content

Add reconfigure to Steam integration - #174696

Merged
erwindouna merged 5 commits into
home-assistant:devfrom
tr4nt0r:steam_reconfigure
Jun 26, 2026
Merged

Add reconfigure to Steam integration#174696
erwindouna merged 5 commits into
home-assistant:devfrom
tr4nt0r:steam_reconfigure

Conversation

@tr4nt0r

@tr4nt0r tr4nt0r commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies a diff between library versions and ideally a link to the changelog/release notes is added to the PR description.

To help with the load of incoming pull requests:

Copilot AI review requested due to automatic review settings June 24, 2026 22:41
@home-assistant

Copy link
Copy Markdown
Contributor

Hey there @tkdrob, mind taking a look at this pull request as it has been labeled with an integration (steam_online) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of steam_online can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant mark-draft Mark the pull request as draft.
  • @home-assistant ready-for-review Remove the draft status from the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign steam_online Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant update-branch Update the pull request branch with the base branch.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) on the pull request.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a reconfigure flow to the Steam (steam_online) integration, allowing users to update their Steam Web API key via the UI's reconfigure option. It builds on the existing reauth flow by reusing the async_step_reauth_confirm logic, branching on the flow source to pick the correct config entry and form step, and adds the name placeholder needed for the reconfigure title.

Changes:

  • Added async_step_reconfigure that reuses async_step_reauth_confirm, with source-based selection of the entry (_get_reauth_entry vs _get_reconfigure_entry), step ID, and a name description placeholder.
  • Added reconfigure step and reconfigure_successful abort strings in strings.json, reusing existing user-step API key strings.
  • Added tests covering the reconfigure happy path and error scenarios, mirroring the existing reauth tests.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
homeassistant/components/steam_online/config_flow.py Adds the reconfigure step and adapts the shared reauth/reconfigure confirm logic and placeholders.
homeassistant/components/steam_online/strings.json Adds reconfigure step strings and the reconfigure_successful abort message.
tests/components/steam_online/test_config_flow.py Adds reconfigure success and error test cases mirroring the reauth tests.

Comment thread tests/components/steam_online/test_config_flow.py Outdated
@home-assistant
home-assistant Bot marked this pull request as draft June 25, 2026 08:31
@home-assistant

Copy link
Copy Markdown
Contributor

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@tr4nt0r
tr4nt0r marked this pull request as ready for review June 25, 2026 14:46
Copilot AI review requested due to automatic review settings June 25, 2026 14:46
@home-assistant
home-assistant Bot requested a review from erwindouna June 25, 2026 14:46

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

Comment thread homeassistant/components/steam_online/strings.json Outdated
Copilot AI review requested due to automatic review settings June 25, 2026 15:01

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

Comment thread homeassistant/components/steam_online/config_flow.py Outdated
@home-assistant
home-assistant Bot marked this pull request as draft June 25, 2026 16:43
This reverts commit f1a6d61.
@tr4nt0r
tr4nt0r force-pushed the steam_reconfigure branch from 24d953e to 3306dd8 Compare June 25, 2026 16:47
Copilot AI review requested due to automatic review settings June 25, 2026 16:48

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

@tr4nt0r
tr4nt0r marked this pull request as ready for review June 25, 2026 16:53
@home-assistant
home-assistant Bot requested a review from erwindouna June 25, 2026 16:53

@erwindouna erwindouna left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last nit, and then it looks good. :)

Comment thread homeassistant/components/steam_online/config_flow.py Outdated
@home-assistant
home-assistant Bot marked this pull request as draft June 26, 2026 06:10
@tr4nt0r
tr4nt0r force-pushed the steam_reconfigure branch from 98ea7c3 to f5615d3 Compare June 26, 2026 14:41
Copilot AI review requested due to automatic review settings June 26, 2026 14:41

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

@tr4nt0r
tr4nt0r marked this pull request as ready for review June 26, 2026 14:45
@home-assistant
home-assistant Bot requested a review from erwindouna June 26, 2026 14:45

@erwindouna erwindouna left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tr4nt0r!

@erwindouna
erwindouna merged commit 585dd72 into home-assistant:dev Jun 26, 2026
33 checks passed
@tr4nt0r
tr4nt0r deleted the steam_reconfigure branch June 26, 2026 15:02
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 27, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants