Rename "advanced_options" section to "additional_options" in DNS IP - #175105
Merged
Conversation
home-assistant
Bot
added
cla-signed
code-quality
has-tests
integration: dnsip
small-pr
Contributor
|
Hey there @gjohansson-ST, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR completes the rename of the config-flow section advanced_options to additional_options in the dnsip integration. It is a follow-up to #174628 (which only changed the user-facing string name) and resolves the "Advanced/Expert" terminology cleanup tracked in #174044 and #173016. The change renames the constant, schema key, internal variables, translation references, and corresponding tests so the codebase is internally consistent.
Changes:
- Renamed
CONF_ADVANCED_OPTIONS→CONF_ADDITIONAL_OPTIONS("advanced_options"→"additional_options"). - Updated the config-flow schema, internal variable names, and all
strings.jsonsection key + reference paths. - Updated tests to use the new constant and renamed
test_form_with_advanced_options→test_form_with_additional_options.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| homeassistant/components/dnsip/const.py | Renames the constant value to additional_options. |
| homeassistant/components/dnsip/config_flow.py | Uses the new constant and variable names in the schema and user step. |
| homeassistant/components/dnsip/strings.json | Updates the section key and all translation reference paths. |
| tests/components/dnsip/test_config_flow.py | Updates imports, payload keys, and the renamed test function. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Rename the section
advanced_optionstoadditional_options. This is a follow up to #174628, where I previously only changed the user-facing string. This PR cleans up the rest. I didn't realize this was wanted before (#174056 (comment)), but I think it makes sense.Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: