Skip to content

Rename "advanced_settings" section to "additional_settings" in Telegram bot - #175107

Merged
joostlek merged 1 commit into
devfrom
justanotherariel-rename-advanced-key-telegram-bot
Jun 29, 2026
Merged

Rename "advanced_settings" section to "additional_settings" in Telegram bot#175107
joostlek merged 1 commit into
devfrom
justanotherariel-rename-advanced-key-telegram-bot

Conversation

@justanotherariel

Copy link
Copy Markdown
Member

Breaking change

Proposed change

Rename the section advanced_settings to additional_settings, and simplify a redundant section lookup for the proxy URL. This is a follow up to #174632, where I previously only changed the user-facing string. This PR cleans up the rest. I didn't realize this was wanted before (#174056 (comment)), but I think it makes sense.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies a diff between library versions and ideally a link to the changelog/release notes is added to the PR description.

To help with the load of incoming pull requests:

Copilot AI review requested due to automatic review settings June 29, 2026 10:48
@home-assistant home-assistant Bot added cla-signed code-quality has-tests integration: telegram_bot small-pr PRs with less than 30 lines. Top 200 Integration is ranked within the top 200 by usage labels Jun 29, 2026
@home-assistant

Copy link
Copy Markdown
Contributor

Hey there @hanwg, mind taking a look at this pull request as it has been labeled with an integration (telegram_bot) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of telegram_bot can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant mark-draft Mark the pull request as draft.
  • @home-assistant ready-for-review Remove the draft status from the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign telegram_bot Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant update-branch Update the pull request branch with the base branch.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) on the pull request.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR completes a code-quality follow-up to #174632 by renaming the Telegram bot config flow section key from advanced_settings to additional_settings, aligning the constant, strings, and tests with the user-facing string already changed previously. It also removes a redundant section lookup for the proxy URL by reusing the value already extracted into CONF_PROXY_URL.

Changes:

  • Renamed SECTION_ADVANCED_SETTINGSSECTION_ADDITIONAL_SETTINGS (const, config_flow, strings, tests) and updated the advanced_settings section key to additional_settings.
  • Simplified the duplicate proxy URL section lookup in async_step_user to reuse user_input[CONF_PROXY_URL].

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
homeassistant/components/telegram_bot/const.py Renamed section constant to SECTION_ADDITIONAL_SETTINGS.
homeassistant/components/telegram_bot/strings.json Updated section key and translation references to additional_settings.
homeassistant/components/telegram_bot/config_flow.py Applied rename throughout and simplified redundant proxy URL lookup.
tests/components/telegram_bot/test_config_flow.py Updated imports/usages to the renamed constant.
tests/components/telegram_bot/test_telegram_bot.py Updated imports/usages to the renamed constant.

@joostlek
joostlek merged commit 5b8ff19 into dev Jun 29, 2026
34 checks passed
@joostlek
joostlek deleted the justanotherariel-rename-advanced-key-telegram-bot branch June 29, 2026 12:48
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 30, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed code-quality has-tests integration: telegram_bot Quality Scale: gold small-pr PRs with less than 30 lines. Top 200 Integration is ranked within the top 200 by usage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants