Rename "advanced_settings" section to "additional_settings" in Telegram bot - #175107
Merged
Merged
Conversation
Contributor
|
Hey there @hanwg, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR completes a code-quality follow-up to #174632 by renaming the Telegram bot config flow section key from advanced_settings to additional_settings, aligning the constant, strings, and tests with the user-facing string already changed previously. It also removes a redundant section lookup for the proxy URL by reusing the value already extracted into CONF_PROXY_URL.
Changes:
- Renamed
SECTION_ADVANCED_SETTINGS→SECTION_ADDITIONAL_SETTINGS(const, config_flow, strings, tests) and updated theadvanced_settingssection key toadditional_settings. - Simplified the duplicate proxy URL section lookup in
async_step_userto reuseuser_input[CONF_PROXY_URL].
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| homeassistant/components/telegram_bot/const.py | Renamed section constant to SECTION_ADDITIONAL_SETTINGS. |
| homeassistant/components/telegram_bot/strings.json | Updated section key and translation references to additional_settings. |
| homeassistant/components/telegram_bot/config_flow.py | Applied rename throughout and simplified redundant proxy URL lookup. |
| tests/components/telegram_bot/test_config_flow.py | Updated imports/usages to the renamed constant. |
| tests/components/telegram_bot/test_telegram_bot.py | Updated imports/usages to the renamed constant. |
joostlek
approved these changes
Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Rename the section
advanced_settingstoadditional_settings, and simplify a redundant section lookup for the proxy URL. This is a follow up to #174632, where I previously only changed the user-facing string. This PR cleans up the rest. I didn't realize this was wanted before (#174056 (comment)), but I think it makes sense.Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: