Bump librouteros to 4.1.1 - #175116
Conversation
|
Hey there @engrbm87, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
|
Caution Review failedAn error occurred during the review process. Please try again later. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
1 similar comment
|
Caution Review failedAn error occurred during the review process. Please try again later. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Check requirementsChecked at commit
📦 librouteros: 3.2.1 → 4.1.1
|
|
This is marked as bugfix. Can you detail what is being fixed in the PR description? |
Isn't the link to changelog enough ? |
No that's for the dependency bump, but this was marked as bugfix, but the PR doesn't describe what its fixing, so Abilio is curious if this was a mistake or that it's fixing something and should be taken into beta |
Humm, I don't get teh point. The new library version fixes a few issues which is the reason why I marked the bump as a bugfix. |
Every dependency bump has a link to the changelog, but not every dependency bump is marked as a bugfix. Otherwise, don't mark it as bugfix. |
|
I am not sure how consistent we are with that. I do think it would make it better if we'd be stricter, but if I open a diff and see a bugfix in the comments in a way that would affect the integration I'd already be fine, but that's not water tight of course |
|
This is the way I always created the bump PR and it was always accepted ;-) Anyway, let's move on; details added. Can I merge the changes? |
Ofc :) I approved it, so it LGTM! I commented because I would like some more details on the PR body, but that was not blocking. Thanks for adding it. |
Proposed change
changelog: https://github.com/luqasz/librouteros/blob/main/CHANGELOG.rst
diff: luqasz/librouteros@3.2.1...4.1.1
Code aligned with breaking changes.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: