Log switcher_kis device ip change - #175289
Merged
Merged
Conversation
When a broadcast arrives for a known device from a different ip address, log the old and new ip. This makes DHCP moves visible in the logs, which helps when diagnosing connectivity to a device that changed address.
home-assistant
Bot
added
cla-signed
code-quality
has-tests
integration: switcher_kis
small-pr
Contributor
|
Hey there @thecode, @YogevBokobza, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
22 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds an info-level log entry to the switcher_kis integration when a known device is seen via broadcast with a different IP address, making DHCP/renumbering events visible for troubleshooting without changing coordinator update behavior.
Changes:
- Log an info message when an existing device’s broadcast IP differs from the coordinator’s current IP.
- Add a test that simulates an IP move and asserts both the log output and coordinator data update.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
homeassistant/components/switcher_kis/__init__.py |
Logs old/new IP when an existing device’s broadcast IP changes before updating coordinator data. |
tests/components/switcher_kis/test_init.py |
Adds a regression test covering IP change logging and coordinator IP update. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
When a broadcast arrives for a known
switcher_kisdevice from a different ipaddress, log the old and new ip at info level. This makes DHCP moves visible in
the logs, which helps when diagnosing connectivity to a device that changed
address. Behavior is otherwise unchanged: the coordinator still updates on
every broadcast.
This is a small, independent follow-up split out of
#175282 (poll switcher_kis devices before marking them
unavailable) at codeowner request. It stands alone against current
devandneeds no dependency change. #175282 is the primary change; this one is minor.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: