Remove unnecessary HTTP configuration from hassio component tests - #175393
Merged
Conversation
Contributor
|
Hey there @home-assistant/supervisor, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Since we migrated the http config to the UI, the yaml config is imported and needs to be confirmed if it is not the same as the previously saved recovery config (promoted as stable config during migration). With #174428 we will automatically revert the imported config, if not promoted to stable within 5 minutes. Several hassio tests did simulate time ticks more than 5 minutes and as no test did promote the config to stable, a revert was triggered, which failed these tests (See https://github.com/home-assistant/core/actions/runs/28585039573/job/84783806381?pr=174428). The config for these tests is:
{"http": {"server_port": 9999, "server_host": "127.0.0.1"}, "hassio": {}}This was copy-pasted from the API-push tests in test_init.py, which legitimately assert that hassio forwards the configured Core port to the Supervisor (set_options(port=9999)) and historically exercised the now-removed server_host/watchdog behavior. The sensor, binary_sensor, switch, update, websocket_api and diagnostics tests never assert on the port or host, so it is leftover boilerplate.
Since hassio declares http as a dependency, setting up hassio already sets up http with its defaults, making the explicit configuration unnecessary and by not specifying a custom http config, nothing needs to be imported and so we don't have a pending config.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: