Skip to content

Remove unnecessary HTTP configuration from hassio component tests - #175393

Merged
edenhaus merged 1 commit into
port-8123from
edenhaus/hassio-test
Jul 3, 2026
Merged

Remove unnecessary HTTP configuration from hassio component tests#175393
edenhaus merged 1 commit into
port-8123from
edenhaus/hassio-test

Conversation

@edenhaus

@edenhaus edenhaus commented Jul 2, 2026

Copy link
Copy Markdown
Member

Breaking change

Proposed change

Since we migrated the http config to the UI, the yaml config is imported and needs to be confirmed if it is not the same as the previously saved recovery config (promoted as stable config during migration). With #174428 we will automatically revert the imported config, if not promoted to stable within 5 minutes. Several hassio tests did simulate time ticks more than 5 minutes and as no test did promote the config to stable, a revert was triggered, which failed these tests (See https://github.com/home-assistant/core/actions/runs/28585039573/job/84783806381?pr=174428). The config for these tests is:

{"http": {"server_port": 9999, "server_host": "127.0.0.1"}, "hassio": {}}

This was copy-pasted from the API-push tests in test_init.py, which legitimately assert that hassio forwards the configured Core port to the Supervisor (set_options(port=9999)) and historically exercised the now-removed server_host/watchdog behavior. The sensor, binary_sensor, switch, update, websocket_api and diagnostics tests never assert on the port or host, so it is leftover boilerplate.

Since hassio declares http as a dependency, setting up hassio already sets up http with its defaults, making the explicit configuration unnecessary and by not specifying a custom http config, nothing needs to be imported and so we don't have a pending config.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies a diff between library versions and ideally a link to the changelog/release notes is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant

home-assistant Bot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Hey there @home-assistant/supervisor, mind taking a look at this pull request as it has been labeled with an integration (hassio) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of hassio can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant mark-draft Mark the pull request as draft.
  • @home-assistant ready-for-review Remove the draft status from the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign hassio Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant update-branch Update the pull request branch with the base branch.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) on the pull request.

@agners agners left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@edenhaus
edenhaus merged commit c1dd006 into port-8123 Jul 3, 2026
33 checks passed
@edenhaus
edenhaus deleted the edenhaus/hassio-test branch July 3, 2026 08:51
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 4, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants