Skip to content

Resolve person member entities in search - #175462

Merged
justanotherariel merged 1 commit into
devfrom
frenck/search-person-members
Jul 3, 2026
Merged

Resolve person member entities in search#175462
justanotherariel merged 1 commit into
devfrom
frenck/search-person-members

Conversation

@frenck

@frenck frenck commented Jul 3, 2026

Copy link
Copy Markdown
Member

Breaking change

Proposed change

Every search path in the search integration that walks member or referenced entities (scene, group, automation, script) resolves each entity up to its device, area, floor, config entry, and integration. Person search is the exception: it adds the member device trackers flat. As a result, searching a person never surfaces the device behind their phone tracker, the mobile_app config entry, or the integration providing it.

This change resolves each person member entity up, using the exact same loop pattern scene search uses for its entities. It also fixes a copy/paste comment in the same method (the person method claimed to up resolve "the scene entity").

Tests: the fixture now registers device_tracker.paulus_iphone properly, behind a mobile_app config entry with a device, instead of using an unregistered entity id string. The person search assertion gains the device, config entry, and integration, and the entity search assertion for the tracker picks up the same three from the richer fixture. Fails without the fix.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies a diff between library versions and ideally a link to the changelog/release notes is added to the PR description.

To help with the load of incoming pull requests:

Copilot AI review requested due to automatic review settings July 3, 2026 09:51
@frenck
frenck requested a review from a team as a code owner July 3, 2026 09:51
@home-assistant

home-assistant Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (search) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of search can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant mark-draft Mark the pull request as draft.
  • @home-assistant ready-for-review Remove the draft status from the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign search Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant update-branch Update the pull request branch with the base branch.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) on the pull request.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes the Search integration’s handling of person results so that device tracker member entities are “up-resolved” (device/area/floor/config entry/integration) the same way as other member/referenced-entity search paths (e.g., scenes).

Changes:

  • Update person search to resolve each member entity “up” via the same per-entity loop pattern used by scene search.
  • Correct an inaccurate comment in _async_search_person.
  • Strengthen Search tests by registering a mobile_app-backed device tracker with an associated device/config entry and asserting the additional resolved search results.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
homeassistant/components/search/__init__.py Changes person search to iterate member entities and call _async_resolve_up_entity so related device/config entry/integration data is included.
tests/components/search/test_init.py Improves fixtures to register a real mobile_app device tracker + device/config entry and expands assertions for entity/person search results.

@justanotherariel
justanotherariel merged commit 0a9534a into dev Jul 3, 2026
34 checks passed
@justanotherariel
justanotherariel deleted the frenck/search-person-members branch July 3, 2026 16:05
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 4, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants