Fix swallowed exceptions in deconz actions by mattreim · Pull Request #175646 · home-assistant/core

mattreim · 2026-07-04T23:28:06Z

Breaking change

Proposed change

This PR is the starting point for fixing issue #170606, as I haven't tested it yet.

Type of change

Dependency upgrade
Bugfix (non-breaking change which fixes an issue)
New integration (thank you!)
New feature (which adds functionality to an existing integration)
Deprecation (breaking change to happen in the future)
Breaking change (fix/feature causing existing functionality to break)
Code quality improvements to existing code or addition of tests

Additional information

This PR fixes or closes issue: fixes #
This PR is related to issue:
Link to documentation pull request:
Link to developer documentation pull request:
Link to frontend pull request:

Checklist

I understand the code I am submitting and can explain how it works.
The code change is tested and works locally.
Local tests pass. Your PR cannot be merged unless tests pass
There is no commented out code in this PR.
I have followed the development checklist
I have followed the perfect PR recommendations
The code has been formatted using Ruff (ruff format homeassistant tests)
Tests have been added to verify that the new code works.
Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

The manifest file has all fields filled out correctly.
Updated and included derived files by running: python3 -m script.hassfest.
New or updated dependencies have been added to requirements_all.txt.
Updated by running python3 -m script.gen_requirements_all.
For the updated dependencies a diff between library versions and ideally a link to the changelog/release notes is added to the PR description.

To help with the load of incoming pull requests:

I have reviewed two other open pull requests in this repository.

home-assistant · 2026-07-04T23:28:13Z

Hey there @Kane610, mind taking a look at this pull request as it has been labeled with an integration (deconz) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of deconz can trigger bot actions by commenting:

@home-assistant close Closes the pull request.
@home-assistant mark-draft Mark the pull request as draft.
@home-assistant ready-for-review Remove the draft status from the pull request.
@home-assistant rename Awesome new title Renames the pull request.
@home-assistant reopen Reopen the pull request.
@home-assistant unassign deconz Removes the current integration label and assignees on the pull request, add the integration domain after the command.
@home-assistant update-branch Update the pull request branch with the base branch.
@home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) to the pull request.
@home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) on the pull request.

Copilot

Pull request overview

This PR addresses issue #170606 by fixing swallowed exceptions in the deCONZ integration's action handlers. Previously, several except blocks in services.py only logged errors and returned, so failed actions gave the user no UI feedback and automations continued as if the action succeeded. The change re-raises HomeAssistantError with translated messages instead, and removes the associated pylint: disable-next=home-assistant-action-swallowed-exception suppressions.

Changes:

Replaced log-and-return error handling in async_call_deconz_service, async_configure_service, and async_refresh_devices_service with raised HomeAssistantErrors using new translation keys.
Added an exceptions block to strings.json with five translation keys (gateway_not_found, no_master_gateway, entity_not_found, configure_failed, device_refresh_failed).
Updated existing service tests to assert that HomeAssistantError is now raised (using blocking=True and pytest.raises).

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File	Description
homeassistant/components/deconz/services.py	Re-raises `HomeAssistantError` instead of logging-and-returning; refactors bridge lookup and wraps API calls in try/except; drops unused `LOGGER` import.
homeassistant/components/deconz/strings.json	Adds `exceptions` translation keys referenced by the new error handling.
tests/components/deconz/test_services.py	Updates failure-path tests to expect `HomeAssistantError` with `blocking=True`.

Notes for the author: the two except Exception catches are broader than the integration's established convention (hub/api.py:35, config_flow.py:161 catch (TimeoutError, errors.RequestError, errors.ResponseError)) and will mask unexpected errors; moving load_ignored_devices() into finally changes behavior on refresh failures; and the new configure_failed/device_refresh_failed branches are not yet covered by tests (consistent with the PR description noting it is untested).

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.

mattreim · 2026-07-06T00:22:40Z

@Kane610 Copilot is satisfied for now, and the tests are running successfully, so we can move on to the next step. What do you think?

justanotherariel · 2026-07-06T08:33:54Z

@@ -122,9 +125,15 @@ async def test_configure_service_with_faulty_bridgeid(
        SERVICE_DATA: {"on": True},
    }

-    await hass.services.async_call(DOMAIN, SERVICE_CONFIGURE_DEVICE, service_data=data)
-    await hass.async_block_till_done()
+    with pytest.raises(HomeAssistantError) as err:
+        await hass.services.async_call(
+            DOMAIN,
+            SERVICE_CONFIGURE_DEVICE,
+            service_data=data,
+            blocking=True,
+        )

+    assert err.value.translation_key == "gateway_not_found"
    assert len(aioclient_mock.mock_calls) == 0


@@ -141,26 +150,35 @@ async def test_configure_service_with_faulty_field(hass: HomeAssistant) -> None:

 @pytest.mark.usefixtures("config_entry_setup")
 async def test_configure_service_with_faulty_entity(
-    hass: HomeAssistant, aioclient_mock: AiohttpClientMocker
+    hass: HomeAssistant,
+    aioclient_mock: AiohttpClientMocker,
 ) -> None:
-    """Test that service on a non existing entity."""
+    """Test that service fails on a non-existing entity."""
    aioclient_mock.clear_requests()

    data = {
        SERVICE_ENTITY: "light.nonexisting",
        SERVICE_DATA: {},
    }

-    await hass.services.async_call(DOMAIN, SERVICE_CONFIGURE_DEVICE, service_data=data)
-    await hass.async_block_till_done()
+    with pytest.raises(HomeAssistantError) as err:
+        await hass.services.async_call(
+            DOMAIN,
+            SERVICE_CONFIGURE_DEVICE,
+            service_data=data,
+            blocking=True,
+        )

+    assert err.value.translation_key == "entity_not_found"
+    assert err.value.translation_placeholders == {"entity_id": "light.nonexisting"}
    assert len(aioclient_mock.mock_calls) == 0


 @pytest.mark.parametrize("config_entry_options", [{CONF_MASTER_GATEWAY: False}])
 @pytest.mark.usefixtures("config_entry_setup")
 async def test_calling_service_with_no_master_gateway_fails(
-    hass: HomeAssistant, aioclient_mock: AiohttpClientMocker
+    hass: HomeAssistant,
+    aioclient_mock: AiohttpClientMocker,
 ) -> None:
    """Test that service call fails when no master gateway exist."""
    aioclient_mock.clear_requests()
@@ -170,9 +188,15 @@ async def test_calling_service_with_no_master_gateway_fails(
        SERVICE_DATA: {"on": True},
    }

-    await hass.services.async_call(DOMAIN, SERVICE_CONFIGURE_DEVICE, service_data=data)
-    await hass.async_block_till_done()
+    with pytest.raises(HomeAssistantError) as err:
+        await hass.services.async_call(
+            DOMAIN,
+            SERVICE_CONFIGURE_DEVICE,
+            service_data=data,
+            blocking=True,
+        )

+    assert err.value.translation_key == "no_master_gateway"
    assert len(aioclient_mock.mock_calls) == 0


These could be merged/parameterized

home-assistant · 2026-07-06T08:37:07Z

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

mattreim · 2026-07-06T10:36:54Z

@justanotherariel Thank you very much for your help, and I hope it's okay now.

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

Kane610

Looks good to me, thanks!

justanotherariel

You did a bit more than I asked for regarding the error types - not everything should be a ServiceValidationError. Fixed it for you. Looks good now.

Fix swallowed exceptions in deconz actions

ef9f426

Copilot AI review requested due to automatic review settings July 4, 2026 23:28

mattreim requested a review from Kane610 as a code owner July 4, 2026 23:28

home-assistant Bot added cla-signed has-tests integration: deconz labels Jul 4, 2026

home-assistant Bot assigned Kane610 Jul 4, 2026

home-assistant Bot added the Quality Scale: No score label Jul 4, 2026

Copilot started reviewing on behalf of mattreim July 4, 2026 23:28 View session

Merge branch 'dev' into Fix-swallowed-exceptions-in-deconz-actions

dc5ddb7

Copilot AI reviewed Jul 4, 2026

View reviewed changes

Comment thread homeassistant/components/deconz/services.py Outdated

Comment thread homeassistant/components/deconz/services.py Outdated

Comment thread homeassistant/components/deconz/services.py

Comment thread homeassistant/components/deconz/services.py Outdated

Copilot AI review requested due to automatic review settings July 4, 2026 23:33

Copilot started reviewing on behalf of mattreim July 4, 2026 23:33 View session

Copilot AI reviewed Jul 4, 2026

View reviewed changes

Comment thread homeassistant/components/deconz/services.py Outdated

Comment thread homeassistant/components/deconz/services.py

Comment thread homeassistant/components/deconz/services.py Outdated

Comment thread homeassistant/components/deconz/services.py

mattreim added 2 commits July 5, 2026 02:18

Exception to TimeoutError, errors.RequestError, errors.ResponseError

f2a184f

Merge branch 'dev' into Fix-swallowed-exceptions-in-deconz-actions

1ec50c7

Copilot AI review requested due to automatic review settings July 5, 2026 00:24

Copilot started reviewing on behalf of mattreim July 5, 2026 00:24 View session

Copilot AI reviewed Jul 5, 2026

View reviewed changes

Comment thread homeassistant/components/deconz/services.py

Potential fix for pull request finding

0a87f3c

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings July 5, 2026 00:34

Copilot started reviewing on behalf of mattreim July 5, 2026 00:34 View session

Copilot AI reviewed Jul 5, 2026

View reviewed changes

Comment thread tests/components/deconz/test_services.py Outdated

Comment thread homeassistant/components/deconz/services.py

Comment thread homeassistant/components/deconz/services.py

Potential fix for pull request finding

f8411bb

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings July 5, 2026 00:39

Copilot AI reviewed Jul 5, 2026

View reviewed changes

Comment thread homeassistant/components/deconz/services.py

Comment thread homeassistant/components/deconz/services.py

mattreim added 2 commits July 5, 2026 02:51

Add configure_failed and device_refresh_failed

72fc306

Fix ruff (F821)

6c380ea

Copilot AI review requested due to automatic review settings July 5, 2026 10:30

Copilot AI review requested due to automatic review settings July 5, 2026 23:16

Copilot started reviewing on behalf of mattreim July 5, 2026 23:17 View session

Copilot AI reviewed Jul 5, 2026

View reviewed changes

Comment thread tests/components/deconz/conftest.py Outdated

Comment thread tests/components/deconz/conftest.py Outdated

Comment thread tests/components/deconz/test_services.py Outdated

Comment thread tests/components/deconz/test_services.py Outdated

mattreim added 2 commits July 6, 2026 01:54

Further simplification

7e20711

Merge branch 'dev' into Fix-swallowed-exceptions-in-deconz-actions

0926222

Copilot AI review requested due to automatic review settings July 5, 2026 23:59

Copilot started reviewing on behalf of mattreim July 5, 2026 23:59 View session

Copilot AI reviewed Jul 6, 2026

View reviewed changes

Comment thread tests/components/deconz/test_services.py Outdated

Potential fix for pull request finding

d95cfa5

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings July 6, 2026 00:07

Copilot started reviewing on behalf of mattreim July 6, 2026 00:07 View session

Copilot AI reviewed Jul 6, 2026

View reviewed changes

justanotherariel added the bugfix label Jul 6, 2026

justanotherariel requested changes Jul 6, 2026

View reviewed changes

home-assistant Bot marked this pull request as draft July 6, 2026 08:37

Changes from @justanotherariel

589ae8c

mattreim marked this pull request as ready for review July 6, 2026 10:36

Copilot AI review requested due to automatic review settings July 6, 2026 10:36

home-assistant Bot requested a review from justanotherariel July 6, 2026 10:36

Copilot started reviewing on behalf of mattreim July 6, 2026 10:37 View session

Copilot AI reviewed Jul 6, 2026

View reviewed changes

Comment thread homeassistant/components/deconz/services.py

Comment thread homeassistant/components/deconz/services.py

Kane610 approved these changes Jul 6, 2026

View reviewed changes

Fix error types

65d754e

justanotherariel approved these changes Jul 6, 2026

View reviewed changes

justanotherariel merged commit 7678cf9 into home-assistant:dev Jul 6, 2026
29 checks passed

mattreim mentioned this pull request Jul 6, 2026

Fix swallowed exceptions in deconz action handlers #170606

Open

github-actions Bot locked and limited conversation to collaborators Jul 7, 2026

Uh oh!

Uh oh!

Conversation

mattreim commented Jul 4, 2026 • edited by justanotherariel Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Breaking change

Proposed change

Type of change

Additional information

Checklist

Uh oh!

home-assistant Bot commented Jul 4, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

mattreim commented Jul 6, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

justanotherariel Jul 6, 2026

Choose a reason for hiding this comment

Uh oh!

home-assistant Bot commented Jul 6, 2026

Uh oh!

mattreim commented Jul 6, 2026

Uh oh!

Copilot AI left a comment

mattreim commented Jul 4, 2026 •

edited by justanotherariel

Loading