Add PostgreSQL backend and storage backend selection for KNX telegrams - #175673
Merged
Conversation
Contributor
|
Hey there @Julius2342, @farmio, @marvin-w, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends the KNX integration's telegram storage subsystem (introduced for 2026.07) by adding an external PostgreSQL backend alongside the existing SQLite store, and a backend selector in the options flow. When PostgreSQL is chosen, a second options step collects host/port/user/password/database/TLS, assembles a DSN, validates the connection (10s timeout) with translated error mapping, and stores the DSN in config entry options. The DSN is redacted in diagnostics, the group monitor websocket base data now reports the concrete backend, and the knx-telegram-store dependency is bumped to 0.4.0 with the postgres extra. A config entry migration to v2.2 defaults existing entries to the SQLite backend and moves any DSN from entry data to options.
Changes:
- Add a
telegram_db_backendselector and atelegram_store_postgresoptions step with DSN build/parse/validation helpers and password reuse. - Select
BufferedPostgresStore/BufferedSqliteStoreinTelegrams, surface the backend viaisinstancein the websocket, and redact the DSN in diagnostics. - Bump
knx-telegram-store[sqlite,postgres]==0.4.0, add constants/typed options, migrate entries tov2.2, and add tests for the new flow and init paths.
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
homeassistant/components/knx/config_flow.py |
Adds backend selector, PostgreSQL step, and DSN build/parse/validate helpers |
homeassistant/components/knx/telegrams.py |
Selects SQLite or PostgreSQL store based on configured backend |
homeassistant/components/knx/websocket.py |
Reports concrete backend via isinstance checks on the store |
homeassistant/components/knx/__init__.py |
Adds v2.2 migration setting default backend and moving DSN to options |
homeassistant/components/knx/const.py |
New backend/DSN constants and typed option fields |
homeassistant/components/knx/diagnostics.py |
Redacts the PostgreSQL DSN in diagnostics |
homeassistant/components/knx/strings.json |
Adds selector, form, and error translations |
homeassistant/components/knx/manifest.json |
Bumps dependency to knx-telegram-store[sqlite,postgres]==0.4.0 |
requirements_all.txt |
Mirrors the dependency bump |
tests/components/knx/test_config_flow.py |
Tests the PostgreSQL options flow, DSN parsing, failure/timeout paths |
tests/components/knx/test_telegrams.py |
Tests invalid backend and PostgreSQL init-failure paths |
tests/components/knx/test_init.py |
Tests the v2.x→v2.2 migration |
tests/components/knx/conftest.py |
Adds default backend to the mock config entry options |
tests/components/knx/snapshots/test_diagnostic.ambr |
Updates snapshots for the new option |
martinhoefling
force-pushed
the
pg-addition-rebase
branch
from
July 5, 2026 13:21
41dbcea to
c43d711
Compare
martinhoefling
marked this pull request as ready for review
July 5, 2026 13:22
martinhoefling
force-pushed
the
pg-addition-rebase
branch
from
July 5, 2026 13:23
c43d711 to
c7af8db
Compare
8 tasks
martinhoefling
force-pushed
the
pg-addition-rebase
branch
from
July 5, 2026 13:42
c7af8db to
d0b2432
Compare
martinhoefling
force-pushed
the
pg-addition-rebase
branch
from
July 12, 2026 21:42
f868d92 to
2401782
Compare
Build on the SQLite telegram store by adding an external PostgreSQL
storage backend and a storage-backend selector to the options flow.
- Add a storage backend dropdown ("Internal storage" / "PostgreSQL") to the
communication settings step. SQLite routes to the existing store step;
PostgreSQL routes to a new step collecting host, port, user, password,
database and TLS, assembled into a DSN.
- Validate the PostgreSQL connection (with a 10s timeout) before saving,
mapping connection error kinds to translated form errors.
- Reuse the stored password when the PostgreSQL password field is left
blank and mask credentials when building/parsing the DSN.
- Construct a BufferedPostgresStore when the PostgreSQL backend is selected
and surface the backend in the group monitor websocket base data.
- Redact the telegram DSN in diagnostics.
- Pull in the postgres extra of knx-telegram-store (bumped to 0.4.0).
- Add tests for the PostgreSQL options flow, DSN parsing, invalid backend
handling, connection failure, timeout and the init failure path.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
- Drop DSN data->options migration that never shipped; comment when the 2.2 migration was introduced - Parse current DSN once in the postgres options step - Import knx-telegram-store at module level in config flow - Use else for the sqlite backend branch; remove unreachable invalid-backend handling and its test - Clarify that the TLS option does not verify the server certificate Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AC3osqhYegB84hvFNJLofB
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
- Make the store init and DSN check timeouts patchable constants and exercise real timeout expiry in tests instead of injecting TimeoutError - Annotate knx_setup fixture parameters as AsyncMock - Cover the malformed-DSN ValueError path in the options flow - knx-telegram-store 0.9.0 percent-decodes the database name in DSNs and makes TimescaleDB optional; drop the now unreachable missing_timescaledb form error Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KGK6rMuaq1Zs44Ry6Wk7XS
martinhoefling
force-pushed
the
pg-addition-rebase
branch
from
July 13, 2026 19:57
2eecb4e to
0d76b04
Compare
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KGK6rMuaq1Zs44Ry6Wk7XS
0.9.1 translates libpq's sslmode DSN parameter to asyncpg's ssl connect argument, fixing connections with TLS enabled. Size the write buffer to cover a full flush interval at the maximum KNX TP line rate so telegrams are not dropped between flushes. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KGK6rMuaq1Zs44Ry6Wk7XS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
No, builds on the introduced library for KNX Telegram storage in 2026.07
Proposed change
Build on the SQLite telegram store by adding an external PostgreSQL storage backend and a storage-backend selector to the options flow. Primary use case is to store long term history of KNX Telegrams in a separate time series database from HA for querying and multi tenancy with other analysis tools like Spectrum KNX.
Details
0.3.2->0.9.1). 0.9.0 percent-decodes the database name in DSNs and makes TimescaleDB optional with automatic detection; 0.9.1 translates libpq'ssslmodeDSN parameter to asyncpg'ssslconnect argument so TLS connections work. Release notes: https://github.com/XKNX/knx-telegram-store/releasesType of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: