Remove previously deprecated battery props from Sharkiq - #175691
Merged
Conversation
Contributor
|
Hey there @JeffResc, @funkybunch, @TheOneOgre, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Shark IQ integration’s vacuum platform to remove the previously deprecated battery-related vacuum properties/features, aligning it with the upstream vacuum component breaking change.
Changes:
- Removed
VacuumEntityFeature.BATTERYfrom the Shark IQ vacuum entity supported features. - Removed the
battery_levelproperty implementation from the Shark IQ vacuum entity. - Updated Shark IQ vacuum tests to stop asserting the vacuum battery attribute/feature.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
homeassistant/components/sharkiq/vacuum.py |
Drops battery feature support and removes the battery_level property from the vacuum entity. |
tests/components/sharkiq/test_vacuum.py |
Updates expected supported features and initial attribute assertions to no longer include battery. |
joostlek
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Remove previously deprecated battery props from Sharkiq
vacuumplatformProposed change
Linked to: #175682
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: