Skip to content

Remove previously deprecated battery props from Sharkiq - #175691

Merged
joostlek merged 1 commit into
devfrom
gj-20260705-11
Jul 6, 2026
Merged

Remove previously deprecated battery props from Sharkiq#175691
joostlek merged 1 commit into
devfrom
gj-20260705-11

Conversation

@gjohansson-ST

@gjohansson-ST gjohansson-ST commented Jul 5, 2026

Copy link
Copy Markdown
Member

Breaking change

Remove previously deprecated battery props from Sharkiq vacuum platform

Proposed change

Linked to: #175682

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]
  • I have followed the [perfect PR recommendations][perfect-pr]
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

  • Documentation added/updated for [www.home-assistant.io][docs-repository]

If the code communicates with devices, web services, or third-party tools:

  • The [manifest file][manifest-docs] has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies a diff between library versions and ideally a link to the changelog/release notes is added to the PR description.

To help with the load of incoming pull requests:

  • I have reviewed two other [open pull requests][prs] in this repository.

Copilot AI review requested due to automatic review settings July 5, 2026 15:54
@home-assistant

home-assistant Bot commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

Hey there @JeffResc, @funkybunch, @TheOneOgre, mind taking a look at this pull request as it has been labeled with an integration (sharkiq) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of sharkiq can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant mark-draft Mark the pull request as draft.
  • @home-assistant ready-for-review Remove the draft status from the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign sharkiq Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant update-branch Update the pull request branch with the base branch.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) on the pull request.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Shark IQ integration’s vacuum platform to remove the previously deprecated battery-related vacuum properties/features, aligning it with the upstream vacuum component breaking change.

Changes:

  • Removed VacuumEntityFeature.BATTERY from the Shark IQ vacuum entity supported features.
  • Removed the battery_level property implementation from the Shark IQ vacuum entity.
  • Updated Shark IQ vacuum tests to stop asserting the vacuum battery attribute/feature.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
homeassistant/components/sharkiq/vacuum.py Drops battery feature support and removes the battery_level property from the vacuum entity.
tests/components/sharkiq/test_vacuum.py Updates expected supported features and initial attribute assertions to no longer include battery.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

@joostlek
joostlek merged commit 4036b5b into dev Jul 6, 2026
35 checks passed
@joostlek
joostlek deleted the gj-20260705-11 branch July 6, 2026 11:20
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 7, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants