Skip to content

Use serial port selector in Monoprice config flow - #175707

Merged
balloob merged 2 commits into
home-assistant:devfrom
OnFreund:claude/vibrant-burnell-a63529
Jul 5, 2026
Merged

Use serial port selector in Monoprice config flow#175707
balloob merged 2 commits into
home-assistant:devfrom
OnFreund:claude/vibrant-burnell-a63529

Conversation

@OnFreund

@OnFreund OnFreund commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

Now that pymonoprice uses serialx, switch the config flow's port field from a plain text input to SerialPortSelector, matching the pattern used by denon_rs232 and russound_rio.

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies a diff between library versions and ideally a link to the changelog/release notes is added to the PR description.

To help with the load of incoming pull requests:

Now that pymonoprice uses serialx, switch the config flow's port field
from a plain text input to SerialPortSelector, matching the pattern
used by denon_rs232 and russound_rio.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@home-assistant

home-assistant Bot commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

Hey there @etsinko, mind taking a look at this pull request as it has been labeled with an integration (monoprice) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of monoprice can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant mark-draft Mark the pull request as draft.
  • @home-assistant ready-for-review Remove the draft status from the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign monoprice Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant update-branch Update the pull request branch with the base branch.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) on the pull request.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Monoprice 6-Zone Amplifier config flow to use SerialPortSelector for the port field instead of a plain str text input. This follows a recent migration where pymonoprice began using serialx, and aligns the integration with the serial-port UX pattern already used by integrations like denon_rs232 and russound_rio. The change gives users a selectable list of detected serial ports rather than requiring them to type the device path.

Changes:

  • Import SerialPortSelector from homeassistant.helpers.selector.
  • Replace vol.Required(CONF_PORT): str with vol.Required(CONF_PORT): SerialPortSelector() in DATA_SCHEMA.

Comment thread homeassistant/components/monoprice/config_flow.py
SerialPortSelector populates its dropdown via the usb integration's
list_serial_ports websocket command, which is only registered once
usb is set up. denon_rs232 and russound_rio, cited as the pattern
this integration follows, both declare the dependency.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@OnFreund
OnFreund marked this pull request as ready for review July 5, 2026 17:49
Copilot AI review requested due to automatic review settings July 5, 2026 17:49
@balloob
balloob merged commit 71c6bd2 into home-assistant:dev Jul 5, 2026
33 checks passed
@OnFreund
OnFreund deleted the claude/vibrant-burnell-a63529 branch July 5, 2026 17:50

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

"name": "Monoprice 6-Zone Amplifier",
"codeowners": ["@etsinko", "@OnFreund"],
"config_flow": true,
"dependencies": ["usb"],
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 6, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants