Add renew authentication token in additional coordinators for solarlog - #175773
Draft
dontinelli wants to merge 1 commit into
Draft
Add renew authentication token in additional coordinators for solarlog#175773dontinelli wants to merge 1 commit into
dontinelli wants to merge 1 commit into
Conversation
home-assistant
Bot
added
bugfix
cla-signed
has-tests
integration: solarlog
small-pr
Contributor
|
Hey there @Ernst79, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request updates the Solar-Log integration to renew the authentication token not only in the basic coordinator, but also when authentication errors occur in the device-data and longtime-energy coordinators, addressing periodic re-authentication problems reported by users.
Changes:
- Attempt token renewal from
SolarLogDeviceDataCoordinatorwhen inverter-data updates hitSolarLogAuthenticationError. - Attempt token renewal from
SolarLogLongtimeDataCoordinatorwhen energy-data updates hitSolarLogAuthenticationError. - Add tests that validate the coordinators surface
ConfigEntryAuthFailedafter auth errors during scheduled refresh.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
homeassistant/components/solarlog/coordinator.py |
Adds token-renewal attempts on auth failures in device and longtime coordinators. |
tests/components/solarlog/test_init.py |
Adds refresh-time exception handling tests for the device and longtime coordinators. |
Comment on lines
156
to
+160
| except SolarLogAuthenticationError as ex: | ||
| # check, if only access token has expired, try to renew it and retry data update | ||
| if await self.config_entry.runtime_data.basic_data_coordinator.renew_authentication(): | ||
| # login was successful, retry data update | ||
| raise UpdateFailed( |
Comment on lines
295
to
+299
| except SolarLogAuthenticationError as ex: | ||
| # check, if only access token has expired, try to renew it and retry data update | ||
| if await self.config_entry.runtime_data.basic_data_coordinator.renew_authentication(): | ||
| # login was successful, retry data update | ||
| raise UpdateFailed( |
Comment on lines
+128
to
+132
| async def test_devicedatacoordinator_exceptions_during_refresh( | ||
| hass: HomeAssistant, | ||
| mock_config_entry: MockConfigEntry, | ||
| mock_solarlog_connector: AsyncMock, | ||
| freezer: FrozenDateTimeFactory, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Currently only in the basic data update coordinator a renewal of the authentication token is made. This fix adds a renewal also for the other coordinators, as apparently there are users experiencing problems when the token expires and is not renewed automatically.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: