Skip to content

Use EntityStateAttribute enum in PEGELONLINE - #176403

Merged
mib1185 merged 1 commit into
devfrom
epenet/20260713-pegel_online-entity-state-attribute
Jul 13, 2026
Merged

Use EntityStateAttribute enum in PEGELONLINE#176403
mib1185 merged 1 commit into
devfrom
epenet/20260713-pegel_online-entity-state-attribute

Conversation

@epenet

@epenet epenet commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Breaking change

Proposed change

The coordinates in the entity state attributes now use EntityStateAttribute.LATITUDE/EntityStateAttribute.LONGITUDE instead of the ambiguous ATTR_LATITUDE/ATTR_LONGITUDE constants.

Part of #174209.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies a diff between library versions and ideally a link to the changelog/release notes is added to the PR description.

To help with the load of incoming pull requests:

Copilot AI review requested due to automatic review settings July 13, 2026 12:45

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@home-assistant

Copy link
Copy Markdown
Contributor

Hey there @mib1185, mind taking a look at this pull request as it has been labeled with an integration (pegel_online) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of pegel_online can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant mark-draft Mark the pull request as draft.
  • @home-assistant ready-for-review Remove the draft status from the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign pegel_online Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant update-branch Update the pull request branch with the base branch.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) on the pull request.

@epenet
epenet marked this pull request as ready for review July 13, 2026 12:47
@epenet
epenet requested a review from mib1185 as a code owner July 13, 2026 12:47
@mib1185
mib1185 merged commit 431ed2b into dev Jul 13, 2026
33 checks passed
@mib1185
mib1185 deleted the epenet/20260713-pegel_online-entity-state-attribute branch July 13, 2026 15:32
tr4nt0r pushed a commit to tr4nt0r/ha-core that referenced this pull request Jul 13, 2026
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 14, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants