Make _LOGGER public in starline - #177331
Merged
Merged
Conversation
home-assistant
Bot
added
cla-signed
code-quality
integration: starline
small-pr
Contributor
|
Hey there @Anonym-tsk, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Contributor
There was a problem hiding this comment.
Pull request overview
Renames StarLine’s exported logger constant from _LOGGER to public LOGGER, resolving #177317.
Changes:
- Renames the logger constant.
- Updates all imports and usages.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
homeassistant/components/starline/const.py |
Exposes LOGGER publicly. |
homeassistant/components/starline/config_flow.py |
Uses the renamed logger. |
homeassistant/components/starline/account.py |
Uses the renamed logger. |
mib1185
approved these changes
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Rename the exported
_LOGGERconstant in thestarlineintegration toLOGGER. Since the constant is exported fromconst.pyand imported by other modules, it should be public, as tracked in epic home-assistant/epics#115. The logger name itself is unchanged, only the constant name changes. The import and all usages inconfig_flow.pyandaccount.pyare updated accordingly.Type of change
Additional information
_LOGGERpublic instarline#177317_LOGGERpublic when it is an exported constant epics#115Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: