Skip to content

mikrotik: Don't reuse a string from Vodafone Station - #178455

Merged
joostlek merged 1 commit into
home-assistant:devfrom
reedy:patch-1
Aug 7, 2026
Merged

mikrotik: Don't reuse a string from Vodafone Station#178455
joostlek merged 1 commit into
home-assistant:devfrom
reedy:patch-1

Conversation

@reedy

@reedy reedy commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Proposed change

Fixes a message reuse, which use the name of a different integration, which may be confusing as they do not have a "Vodafone Station" but a "Mikrotik device"/"Mikrotik router".

Was added in 2026.8.0 in 357bff6

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies a diff between library versions and ideally a link to the changelog/release notes is added to the PR description.

To help with the load of incoming pull requests:

@reedy
reedy requested a review from chemelli74 as a code owner August 7, 2026 11:08
Copilot AI balanced review requested due to automatic review settings August 7, 2026 11:08
@home-assistant

home-assistant Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Hey there @engrbm87, @chemelli74, mind taking a look at this pull request as it has been labeled with an integration (mikrotik) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of mikrotik can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant mark-draft Mark the pull request as draft.
  • @home-assistant ready-for-review Remove the draft status from the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign mikrotik Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant update-branch Update the pull request branch with the base branch.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) on the pull request.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes the MikroTik reauthentication prompt so it no longer references Vodafone Station.

Changes:

  • Replaces the reused Vodafone Station password description with MikroTik-specific text.

@joostlek joostlek added this to the 2026.8.1 milestone Aug 7, 2026
@joostlek
joostlek merged commit 34d72cf into home-assistant:dev Aug 7, 2026
33 checks passed
@reedy
reedy deleted the patch-1 branch August 7, 2026 11:43
@bramkragten bramkragten mentioned this pull request Aug 7, 2026
gabrielcosi pushed a commit to gabrielcosi/home-ops that referenced this pull request Aug 7, 2026
…2026.8.0 ➔ 2026.8.1) (#316)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [ghcr.io/home-operations/home-assistant](https://ghcr.io/home-operations/home-assistant) ([source](https://github.com/home-assistant/core)) | patch | `2026.8.0` → `2026.8.1` |

---

### Release Notes

<details>
<summary>home-assistant/core (ghcr.io/home-operations/home-assistant)</summary>

### [`v2026.8.1`](https://github.com/home-assistant/core/releases/tag/2026.8.1)

[Compare Source](home-assistant/core@2026.8.0...2026.8.1)

- Fixes [#&#8203;173399](home-assistant/core#173399) Seerr webhook registration ([@&#8203;shtefko] - [#&#8203;177201]) ([overseerr docs])
- Debounce Matter cover state writes to coalesce split attribute updates ([@&#8203;agners] - [#&#8203;177540]) ([matter docs])
- Bump pydaikin to 2.18.4 ([@&#8203;fredrike] - [#&#8203;178001]) ([daikin docs])
- Adapt vicare to set via\_device\_id in DeviceInfo ([@&#8203;emontnemery] - [#&#8203;178229]) ([vicare docs])
- Adapt mqtt to set via\_device\_id in DeviceInfo ([@&#8203;emontnemery] - [#&#8203;178234]) ([mqtt docs])
- bump pyenphase to 3.2.1 ([@&#8203;catsmanac] - [#&#8203;178273]) ([enphase\_envoy docs][enphase_envoy docs])
- Bump lyngdorf to 1.4.3 ([@&#8203;fishloa] - [#&#8203;178323]) ([lyngdorf docs])
- Track shielded service call task in REST API ([@&#8203;arturpragacz] - [#&#8203;178377]) ([api docs])
- Bump aiowebostv to v0.9.1 ([@&#8203;thecode] - [#&#8203;178384]) ([webostv docs])
- chore: update python-picnic-api2 to v2.0.1 ([@&#8203;codesalatdev] - [#&#8203;178395]) ([picnic docs])
- Bump lyngdorf to 1.4.4 ([@&#8203;fishloa] - [#&#8203;178401]) ([lyngdorf docs])
- Use SmartThings cooling setpoint range for air conditioners ([@&#8203;StellarSea] - [#&#8203;178430]) ([smartthings docs])
- Bump solaredge-web to 0.3.1 ([@&#8203;tronikos] - [#&#8203;178437]) ([solaredge docs])
- Bump pytrydan to 1.0.5 ([@&#8203;dgomes] - [#&#8203;178447]) ([v2c docs])
- mikrotik: Don't reuse a string from Vodafone Station ([@&#8203;reedy] - [#&#8203;178455]) ([mikrotik docs])
- Update frontend to [`2026072`](https://github.com/home-assistant/core/commit/20260729).6 ([@&#8203;bramkragten] - [#&#8203;178470]) ([frontend docs])

[#&#8203;177201]: home-assistant/core#177201

[#&#8203;177540]: home-assistant/core#177540

[#&#8203;177559]: home-assistant/core#177559

[#&#8203;178001]: home-assistant/core#178001

[#&#8203;178229]: home-assistant/core#178229

[#&#8203;178234]: home-assistant/core#178234

[#&#8203;178273]: home-assistant/core#178273

[#&#8203;178323]: home-assistant/core#178323

[#&#8203;178377]: home-assistant/core#178377

[#&#8203;178384]: home-assistant/core#178384

[#&#8203;178395]: home-assistant/core#178395

[#&#8203;178401]: home-assistant/core#178401

[#&#8203;178430]: home-assistant/core#178430

[#&#8203;178437]: home-assistant/core#178437

[#&#8203;178447]: home-assistant/core#178447

[#&#8203;178455]: home-assistant/core#178455

[#&#8203;178470]: home-assistant/core#178470

[@&#8203;StellarSea]: https://github.com/StellarSea

[@&#8203;agners]: https://github.com/agners

[@&#8203;arturpragacz]: https://github.com/arturpragacz

[@&#8203;bramkragten]: https://github.com/bramkragten

[@&#8203;catsmanac]: https://github.com/catsmanac

[@&#8203;codesalatdev]: https://github.com/codesalatdev

[@&#8203;dgomes]: https://github.com/dgomes

[@&#8203;emontnemery]: https://github.com/emontnemery

[@&#8203;fishloa]: https://github.com/fishloa

[@&#8203;fredrike]: https://github.com/fredrike

[@&#8203;reedy]: https://github.com/reedy

[@&#8203;shtefko]: https://github.com/shtefko

[@&#8203;thecode]: https://github.com/thecode

[@&#8203;tronikos]: https://github.com/tronikos

[api docs]: https://www.home-assistant.io/integrations/api/

[daikin docs]: https://www.home-assistant.io/integrations/daikin/

[enphase_envoy docs]: https://www.home-assistant.io/integrations/enphase_envoy/

[frontend docs]: https://www.home-assistant.io/integrations/frontend/

[lyngdorf docs]: https://www.home-assistant.io/integrations/lyngdorf/

[matter docs]: https://www.home-assistant.io/integrations/matter/

[mikrotik docs]: https://www.home-assistant.io/integrations/mikrotik/

[mqtt docs]: https://www.home-assistant.io/integrations/mqtt/

[overseerr docs]: https://www.home-assistant.io/integrations/overseerr/

[picnic docs]: https://www.home-assistant.io/integrations/picnic/

[smartthings docs]: https://www.home-assistant.io/integrations/smartthings/

[solaredge docs]: https://www.home-assistant.io/integrations/solaredge/

[v2c docs]: https://www.home-assistant.io/integrations/v2c/

[vicare docs]: https://www.home-assistant.io/integrations/vicare/

[webostv docs]: https://www.home-assistant.io/integrations/webostv/

</details>

---

### Configuration

📅 **Schedule**: (in timezone Europe/Berlin)

- Branch creation
  - At any time (no schedule defined)
- Automerge
  - At any time (no schedule defined)

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Mend Renovate CLI](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0NC41LjMiLCJ1cGRhdGVkSW5WZXIiOiI0NC41LjMiLCJ0YXJnZXRCcmFuY2giOiJtYWluIiwibGFiZWxzIjpbInJlbm92YXRlL2NvbnRhaW5lciIsInR5cGUvcGF0Y2giXX0=-->

Reviewed-on: https://git.xcd.dev/gabrielcosi/home-ops/pulls/316
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"The password for your Vodafone Station." on the Mikrotik integration

5 participants