Skip to content

Complete Smart Camera (sp) device support to Tuya - #58301

Merged
balloob merged 1 commit into
devfrom
frenck-2021-2644
Oct 23, 2021
Merged

Complete Smart Camera (sp) device support to Tuya#58301
balloob merged 1 commit into
devfrom
frenck-2021-2644

Conversation

@frenck

@frenck frenck commented Oct 23, 2021

Copy link
Copy Markdown
Member

Proposed change

Almost fully completes support for the Tuya Smart Camera (sp) device category.
Basic camera support was added earlier (with the camera platform), this PR adds all other platforms for this device category.

Missing at this point: Doorbell handling/support, external Chime support, PTZ.

image

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant

Copy link
Copy Markdown

Hey there @tuya, @zlinoliver, @METISU, mind taking a look at this pull request as it has been labeled with an integration (tuya) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@balloob
balloob merged commit 75e561f into dev Oct 23, 2021
@balloob
balloob deleted the frenck-2021-2644 branch October 23, 2021 19:24
natekspencer pushed a commit to natekspencer/home-assistant-core that referenced this pull request Oct 24, 2021
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants