Skip to content

Add option to retrieve SwitchBot Lock encryption key through config flow - #84830

Merged
bdraco merged 3 commits into
home-assistant:devfrom
dsypniewski:switchbot-lock-config-flow
Dec 30, 2022
Merged

Add option to retrieve SwitchBot Lock encryption key through config flow#84830
bdraco merged 3 commits into
home-assistant:devfrom
dsypniewski:switchbot-lock-config-flow

Conversation

@dsypniewski

@dsypniewski dsypniewski commented Dec 30, 2022

Copy link
Copy Markdown
Contributor

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant home-assistant Bot added cla-signed has-tests integration: switchbot merging-to-rc This PR is merging into the RC branch and should probably change the branch to `dev`. new-feature labels Dec 30, 2022
@home-assistant

Copy link
Copy Markdown
Contributor

Hey there @bdraco, @Danielhiversen, @RenierM26, @murtas, @Eloston, mind taking a look at this pull request as it has been labeled with an integration (switchbot) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of switchbot can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Change the title of the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign switchbot Removes the current integration label and assignees on the issue, add the integration domain after the command.

Comment thread homeassistant/components/switchbot/config_flow.py Outdated
Comment thread homeassistant/components/switchbot/config_flow.py Outdated
Comment thread homeassistant/components/switchbot/lock.py Outdated
Comment thread tests/components/switchbot/test_config_flow.py Outdated
@bdraco

bdraco commented Dec 30, 2022

Copy link
Copy Markdown
Member

This PR should target dev. We can tag it for 2023.1.0 to address the concerns raised here:#84673 (comment)

Comment thread homeassistant/components/switchbot/config_flow.py Outdated
@bdraco
bdraco changed the base branch from rc to dev December 30, 2022 05:19
@bdraco
bdraco force-pushed the switchbot-lock-config-flow branch from 79f7d55 to 420dad7 Compare December 30, 2022 05:23
@bdraco
bdraco removed request for a team, Kane610 and mib1185 December 30, 2022 05:23
@bdraco bdraco removed the merging-to-rc This PR is merging into the RC branch and should probably change the branch to `dev`. label Dec 30, 2022
Comment thread homeassistant/components/switchbot/lock.py Outdated
@bdraco bdraco added this to the 2023.1.0 milestone Dec 30, 2022
@bdraco

bdraco commented Dec 30, 2022

Copy link
Copy Markdown
Member

Sorry about the noise. Should have marked it as draft before fixing the branch target

Comment thread homeassistant/components/switchbot/config_flow.py Outdated
Comment thread homeassistant/components/switchbot/strings.json Outdated
Comment thread homeassistant/components/switchbot/translations/en.json Outdated
Comment thread tests/components/switchbot/test_config_flow.py Outdated
Comment thread tests/components/switchbot/test_config_flow.py Outdated
Comment thread tests/components/switchbot/test_config_flow.py Outdated
Comment thread tests/components/switchbot/test_config_flow.py Outdated
Comment thread tests/components/switchbot/test_config_flow.py Outdated
Comment thread tests/components/switchbot/test_config_flow.py Outdated
Comment thread tests/components/switchbot/test_config_flow.py Outdated

@bdraco bdraco left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. This is a much better UX.

@bdraco

bdraco commented Dec 30, 2022

Copy link
Copy Markdown
Member

The lock I ordered was delayed a day so I'll do testing when it arrives in the morning. I think this addresses the concerns, but if anything goes wrong I'll address any quick fixes in a PR, or if its not something I can resolve or it is more involved I'll hide lock support behind a feature flag until it can be fixed.

Comment thread homeassistant/components/switchbot/config_flow.py
Comment thread homeassistant/components/switchbot/config_flow.py
weisserd pushed a commit to weisserd/core that referenced this pull request Dec 30, 2022
frenck pushed a commit that referenced this pull request Dec 30, 2022
…low (#84830)

Co-authored-by: J. Nick Koston <nick@koston.org>
kvanzuijlen pushed a commit to kvanzuijlen/core that referenced this pull request Dec 30, 2022
kvanzuijlen pushed a commit to kvanzuijlen/core that referenced this pull request Dec 30, 2022
@github-actions github-actions Bot locked and limited conversation to collaborators Jan 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants