Fix watch complication gauge ignoring edited min/max range - #5322
Merged
Conversation
The editor's Minimum/Maximum fields store only the edited bound in the per-family options, but gaugeRange(for:) required both per-family bounds before using them — so setting just Maximum (e.g. 40 over the default 0-100) silently kept gauging against the base range, leaving the gauge dot at value/100 instead of value/max. Resolve each bound independently (per-size override, then base), which matches exactly what the editor's fields display. A resolved range that is invalid (max <= min) now hides the gauge instead of falling back to the base range the user no longer sees.
Contributor
There was a problem hiding this comment.
🟢 Ready to approve
The change is narrowly scoped, aligns with the described bug, and is backed by targeted unit tests for the regression and related edge cases.
This review doesn't count toward merge requirements. Sign up for the private preview to control whether Copilot approvals count.
Pull request overview
Fixes how Apple Watch complication gauge ranges are resolved when only one of Minimum/Maximum is edited in per-family options, ensuring the gauge scales against the range the editor actually displays.
Changes:
- Update
WatchComplicationConfig.gaugeRange(for:)to resolve min/max independently (per-family override → base) and validate the final range. - Add unit tests covering base range, full override, partial override (min-only / max-only), per-family isolation, and invalid resolved ranges.
File summaries
| File | Description |
|---|---|
| Tests/Shared/WatchComplicationConfigGaugeRange.test.swift | Adds regression + coverage tests for gauge range resolution across override scenarios. |
| Sources/HAModels/Sources/WatchComplicationConfig.swift | Fixes gauge range resolution logic to correctly combine per-family overrides with base bounds. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.
Contributor
|
Found 4 unused localization strings in the codebase. Click to see detailsTo remove them, run the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AI Policy
Select exactly one option that describes AI usage in this contribution:
Summary
Fixes the watch complication gauge not respecting an edited Minimum/Maximum range. The editor stores only the bound the user actually edited in the per-size options, but
gaugeRange(for:)required both per-size bounds before using them — so setting just Maximum (e.g. 40 over the default 0–100) silently kept scaling the gauge against 0–100, leaving the dot at value/100 instead of value/max.Each bound now resolves independently (per-size override → base), matching exactly what the editor's fields display. Added unit tests covering the regression and the surrounding range-resolution cases.
Screenshots
Reported via in-app feedback: with Minimum 0 / Maximum 40 and a value of 31, the gauge dot sat at ~31% of the arc instead of ~77%. After the fix the dot position matches the configured range.
Link to pull request in Documentation repository
Documentation: home-assistant/companion.home-assistant#
Any other notes
Bug fix only — no documentation change needed.
Generated by Claude Code