build: drop the two repositories on the retired OSSRH host - #72
Merged
Conversation
oss.sonatype.org was retired and now answers 403 to everything, so the two repositories pointing at it could only ever fail. They did so intermittently rather than always, which is what made this hard to attribute: Maven consults a remote repository only when a POM is not already in the local cache, so a warm runner never touched them while a cold one failed the whole build before a single test ran. The same commit passed in one CI run and failed in the next, on a shard unrelated to anything that had changed. Nothing was ever resolved from them. Verified by resolving the full reactor, and then compiling it, against an empty local repository with both removed: BUILD SUCCESS, 2622 artifacts from Central and 12 from JitPack, zero requests to the dead host and zero unresolved artifacts or plugins. pluginRepositories contained only the dead entry, so the block goes with it; Maven consults Central for plugins by default, which the cold compile exercised. The two repositories that remain are load-bearing: git-OpenBankProject serves OBP's own published artifacts and jitpack.io serves the pinned lift-persistence build.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The root
pom.xmldeclared two repositories onoss.sonatype.org(Sonatype OSSRH, the legacy staging/publishing service for Maven Central):scala-tools.releasesoss.sonatype.org/content/repositories/releases/org.sonatype.oss.groups.public(the only<pluginRepository>)oss.sonatype.org/content/groups/publicNeither serves any artifact of its own. The host now answers with a 302 to
repo1.maven.org— Maven Central — which Maven already consults by default:So the two entries were pure duplicates of Central. They added no availability, only failure modes
It failed intermittently rather than always, which is what made it hard to attribute: Maven consults a remote repository only when a POM is not already in the local cache. A warm runner never touched it; a cold one failed the whole build before a single test ran. The same commit passed in one CI run and failed in the next, on a shard unrelated to anything that had changed (
code.api.v1_2_1).<pluginRepositories>contained only the dead entry, so the block goes with it; Maven consults Central for plugins by default.Kept, because they are load-bearing and are not Central duplicates:
git-OpenBankProject(OBP’s own published artifacts) andjitpack.io(the pinnedlift-persistencebuild).Verification
A warm cache cannot demonstrate this either way, so everything below ran against an empty local repository (
-Dmaven.repo.localon a fresh directory), with no mirror rewriting in~/.m2/settings.xml:dependency:go-offline-pl obp-api -am compileoss.sonatype.orgThe compile step matters specifically because it exercises the plugin set, which is what the removed
<pluginRepositories>block would have served. The reactor isobp-commons+obp-api, so both modules are covered.CI: 27/27 green, including
test (2, v1_2_1)— the shard that the 403 had killed.Not covered, stated for completeness: profiles that are not activated by default, and the
mvn deploy/ release path.