Merge upstream#1
Open
hookenz wants to merge 110 commits intohookenz:masterfrom
Open
Conversation
Update README.md
Replace a few subshells with case pattern matching and POSIX parameter expansion. Signed-off-by: Michael A. Smith <msmith3@ebay.com>
Microoptimization
Create utility function to provide a consistent means to test what external commands are installed. Use the POSIX `type` utility, which is a builtin in many shells, instead of the popular, but non- standard `which`. Signed-off-by: Michael A. Smith <msmith3@ebay.com>
Added rpm spec file.
Utility function to test what is installed
Supersedes #136. Thanks to @kojiromike, who did the initial pull request!
Correct All of ShellCheck's Nitpicks
Output Warnings and Errors to Standard Error
Quotes misplacement causes 'ovs-vsctl: : missing column name'
Fix VLAN tag passing to ovs-vsctl
Added support for -H to sent the hostname
Add the optional -l <local interface name> option which allows the local (host-side) interface to be manually specified. Signed-off-by: James Guthrie <james@prodigi.ch>
Ports created on an OVS switch are not automatically removed when a docker container exits. Pipework now detects an existing OVS port and handles it gracefully. Signed-off-by: James Guthrie <james@prodigi.ch>
When adding a new link, it is possible that a link by that name already exists and may be up. In the case that the link is up the process should stop. In the case that the link is down, it should be removed and re-added. Signed-off-by: James Guthrie <james@prodigi.ch>
Add "pipework rule" command for passing args to "ip rule" ; add "pipework tc" for passing args to "tc"
Pipework doesn't populate the openvswitch database with any information about the pipework interface creation. This makes it difficult to glean any information about the container to which an interface is assigned. This patch adds the bridge, interface name, container ID and vlan to the database so other tools can query it. This patch was specifically designed to help tools like dreamcat4's docker image clean up these interfaces when the container is started with something like 'docker run --rm'.
Adding metadata to openvswitch database.
Updated Google's Shell Style Guide link
Updated a dead link
fix: sh doesn't support substr syntax
LXC 3.1.0 mounts two entries in cgroups now instead of one. The code expected one entry to be returned at all times. Added a simple check for this particular case.
Allow to specify host interface via mac address
Fix lxc 3.1.0
Executing `echo "" | wc -l` results in 1, causing the code to expect a cgroup matching the guest name when there is no such cgroup. Check explicitly for empty output in the results of searching the cgroup.
Fix docker container lookup
Use iw command to set the namespace of a wireless interface
Add workaround for cgroupv2 + Minure fixes
Change shebang to /bin/bash
Check if busybox ipcalc is installed
… one using cut.
Revert #252 and replace the bash-specific substitution with a general…
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.