added ALLOW_SECURE_COOKIES env variable & made minor changes to docs#217
Merged
thetronjohnson merged 3 commits intohoppscotch:mainfrom Jul 27, 2024
SanskritiHarmukh:secure-cookies
Merged
added ALLOW_SECURE_COOKIES env variable & made minor changes to docs#217thetronjohnson merged 3 commits intohoppscotch:mainfrom SanskritiHarmukh:secure-cookies
thetronjohnson merged 3 commits intohoppscotch:mainfrom
SanskritiHarmukh:secure-cookies
Conversation
Signed-off-by: SanskritiHarmukh <sanskritiharmukh1908@gmail.com>
balub
suggested changes
Jul 24, 2024
Contributor
There was a problem hiding this comment.
I don't see how this change is relevant to the PR, please remove it from this PR.
Contributor
Author
There was a problem hiding this comment.
Okay, I spotted it while going through docs, thus made changes in this PR itself.
Contributor
There was a problem hiding this comment.
I would suggest mentioning this in the PR desc or someplace else. I have no context regarding this change hence don't want to approve and have something possible wrong merged.
Contributor
Author
There was a problem hiding this comment.
Sure, I have updated the description. Will ask Kiran to review.
Co-authored-by: Balu Babu <balub997@gmail.com>
Co-authored-by: Balu Babu <balub997@gmail.com>
SanskritiHarmukh
changed the title
thetronjohnson
approved these changes
Jul 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.