fixes remaining script issues for this to become a working installation#4
Merged
ralflang merged 1 commit intohorde:masterfrom Mar 17, 2026
Merged
Conversation
…e needed environment variables with -w. Additionally, the sym links in /usr/local/bin are not available to the entrypoint environment, so just used the tools directory where these files reside. Modified: - horde-entrypoint.sh to check proper git dir for existence - scripts referred to from horde-entrypoint to use /usr/local/tools for the runuser commands.
ralflang
approved these changes
Mar 17, 2026
| fi | ||
|
|
||
| if [ ! -d /srv/git/horde ]; then | ||
| if [ ! -d /srv/git/git ]; then |
Member
There was a problem hiding this comment.
This looks suspiciously like "we should remove literal "git" from the path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modified the runuser commands to use -l instead of -u and included the needed environment variables with -w.
Additionally, the sym links in /usr/local/bin are not available to the entrypoint environment, so just used the tools directory where these files reside.
Modified: