feat(imp): add "block remote images only" mode to image replacement preference - #103
Merged
Merged
Conversation
…reference Add a third option to the image_replacement preference (value 2) that shows inline (cid:) images while blocking remote ones. Update the HTML MIME viewer to skip blocking for already-resolved cid: images in this mode, display a distinct notification for remote image blocking, and update the English help text accordingly.
Member
|
Thank you, this is a useful feature. However, if we change the preference type, do we need to actively upgrade older preferences from backend? |
ralflang
self-requested a review
August 5, 2026 08:39
Contributor
Author
|
No database migration is needed. The existing values 0 (show all) and 1 (block all) remain valid and unchanged — existing users will keep their current behavior without any intervention. For my existing users who had a value explicitly set, I will run a one-time update to migrate them to 2 as it is the most sensible default going forward. |
Member
|
OK... I am just thinkt about continuity. It's fine this way. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a third option to the image_replacement preference (value 2) that
shows inline (cid:) images while blocking remote ones. Update the HTML
MIME viewer to skip blocking for already-resolved cid: images in this
mode, display a distinct notification for remote image blocking, and
update the English help text accordingly.
The existing binary block/show preference dates from an era where
blocking all images served both performance and privacy goals. Today,
inline (cid:) images are integral parts of the message content while
remote images are the actual privacy concern, as they allow senders to
confirm delivery and read time. This new mode reflects that distinction
and is set as the new default to align IMP with the behaviour of modern
mail clients.