Skip to content

fix(review): remove expression syntax from a run-block comment - #24

Merged
zfarrell merged 1 commit into
mainfrom
hotfix/expression-in-run-comment
Aug 5, 2026
Merged

fix(review): remove expression syntax from a run-block comment#24
zfarrell merged 1 commit into
mainfrom
hotfix/expression-in-run-comment

Conversation

@zfarrell

@zfarrell zfarrell commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Hotfix. Every PR in the org is blocked behind .github/workflows/claude-pr-review.yml — Please close and reopen the PR to trigger this workflow.

A shell comment in the context step spelled out the Actions expression delimiters to explain that PR title and body deliberately avoid them. Actions parses those delimiters inside a run: block's string value, comments included, and an empty pair is a syntax error — so the workflow was unparseable, every run started with zero jobs, and the required check never reported.

The identical-looking comment that predates this (line 183, under env:) is harmless because it is a YAML comment, stripped by the YAML parser before Actions sees the file. That difference is why this survived review and local YAML validation.

actionlint catches it; the previous suite could not, because yaml.safe_load accepts the file and tests/context-step-test.sh explicitly exempted comments from its delimiter check. Test hardening follows separately — this change is only the reword, to unblock the org.

@zfarrell
zfarrell requested a review from a team as a code owner August 5, 2026 02:18
@zfarrell
zfarrell requested review from shefeek-jinnah and removed request for a team August 5, 2026 02:18
@zfarrell zfarrell closed this Aug 5, 2026
@zfarrell zfarrell reopened this Aug 5, 2026
@zfarrell
zfarrell merged commit 0947fcb into main Aug 5, 2026
2 checks passed
@zfarrell
zfarrell deleted the hotfix/expression-in-run-comment branch August 5, 2026 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant