fix(auth): use the timeout-bounded HTTP client for workspace fetch and auth probe - #233
Merged
Merged
Conversation
…d auth probe Follow-up from #230: cache_workspaces, api_key_authorized_workspaces, and credentials::check_status used bare reqwest::blocking::Client::new(), which has no request timeout — a stalled server could hang 'auth login' or the 4xx auth-status probe (which runs inside error printing) indefinitely. They now share raw_http::build_http_client() (300s cap + TCP keepalive) like every other raw-HTTP path. Test-only localhost clients are left as-is.
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Verified: the three replaced sites are the production workspace-fetch/auth-probe paths, and the remaining bare Client::new() calls are all under the #[cfg(test)] module (line 555+). Drop-in type-compatible change that closes the un-timeouted paths. LGTM.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Second follow-up from #230.
cache_workspaces,api_key_authorized_workspaces, andcredentials::check_statusused barereqwest::blocking::Client::new(), which has no request timeout — a stalled server could hangauth loginor the 4xx auth-status probe (which runs inside error printing viaformat_fail_message) indefinitely.They now share
raw_http::build_http_client()(300s cap + TCP keepalive), the same client #230 adopted for the token endpoints — this removes the last un-timeouted production HTTP paths in the CLI. The three remainingClient::new()sites are#[cfg(test)]helpers hitting localhost, left as-is.Full suite: 308 passed, 0 failed.