chore: release hotdata-marimo v0.1.4#20
Conversation
d84c9ed to
4d510c2
Compare
|
|
||
| ### Changed | ||
|
|
||
| {NOTE} |
There was a problem hiding this comment.
The {NOTE} template placeholder was not replaced. This will ship in the release notes as a literal {NOTE} token. Replace it with the actual changelog entries for 0.1.4 describing what changed in this release.
There was a problem hiding this comment.
Review -- Blocking Issues: CHANGELOG.md line 17 -- the {NOTE} template placeholder was never filled in. The 0.1.4 changelog entry would ship with a literal {NOTE} token instead of release notes. Action Required: Replace {NOTE} in the 0.1.4 Changed section with the actual list of changes for this release before merging.
4d510c2 to
e04999b
Compare
e04999b to
af33dc9
Compare
|
|
||
| ### Changed | ||
|
|
||
| - Migrate dependency from `hotdata-runtime` to `hotdata-framework` (package renamed; no API change). |
There was a problem hiding this comment.
This changelog entry is inaccurate for this release. The migration from hotdata-runtime to hotdata-framework already shipped — the base of this PR (pyproject.toml at 0.1.3) already declares hotdata-framework>=0.2.3, and uv.lock already resolves hotdata-framework. This PR's diff only bumps the version (0.1.3 → 0.1.4) in pyproject.toml and uv.lock; it changes no dependency.
So shipping this line would describe a change that isn't in 0.1.4. Replace it with the entries that actually describe what changed in this release. If this release truly only bumps the version with no functional change, say that explicitly (e.g. "Maintenance release; no functional changes") rather than attributing a prior migration to 0.1.4.
There was a problem hiding this comment.
Review
Blocking Issues
- CHANGELOG.md:17 — The 0.1.4 entry describes 'Migrate dependency from hotdata-runtime to hotdata-framework', but that migration already shipped before this PR. The base commit (0.1.3) already declares hotdata-framework>=0.2.3 in pyproject.toml and resolves it in uv.lock. This PR's diff only bumps the version number; it changes no dependency. The prior {NOTE} placeholder was replaced, but with inaccurate text.
Action Required
- Update the 0.1.4 changelog entry to describe what actually changed in this release. If 0.1.4 is purely a version bump with no functional change, state that explicitly instead of attributing the earlier hotdata-framework migration to this release.
af33dc9 to
b3ad314
Compare
|
|
||
| ### Changed | ||
|
|
||
| - Migrate dependency from `hotdata-runtime` to `hotdata-framework` (package renamed; no API change). |
There was a problem hiding this comment.
This entry is still inaccurate (raised in the prior review, thread #3486666016). The hotdata-runtime → hotdata-framework migration already shipped: the base of this PR (pyproject.toml on master) already declares hotdata-framework>=0.2.3, and there is no hotdata-runtime reference anywhere in the repo. This PR's diff changes no dependency — it only bumps the version 0.1.3 → 0.1.4 in pyproject.toml and uv.lock.
So shipping this line describes a change that isn't in 0.1.4. Replace it with what actually changed. If this release only bumps the version with no functional change, state that explicitly:
| - Migrate dependency from `hotdata-runtime` to `hotdata-framework` (package renamed; no API change). | |
| - Maintenance release; no functional changes. |
There was a problem hiding this comment.
Review
Blocking Issues
- CHANGELOG.md:17 — The {NOTE} placeholder was replaced (prior issue resolved), but the new text attributes the hotdata-runtime to hotdata-framework migration to 0.1.4. That migration already shipped: masters pyproject.toml already declares hotdata-framework>=0.2.3 and no hotdata-runtime reference exists in the repo. This PRs diff changes no dependency — it only bumps the version 0.1.3 to 0.1.4.
Action Required
Replace the 0.1.4 changelog entry so it describes what actually changed in this release. If it is only a version bump with no functional change, say so explicitly (e.g. Maintenance release; no functional changes).
b3ad314 to
8065b33
Compare
Summary
Release hotdata-marimo v0.1.4.
Checklist
pyproject.tomlCHANGELOG.mdupdatedAfter merge, run
./scripts/release.sh publishfrom a cleanmastercheckout.