Merged
Conversation
Contributor
|
@categulario I see that there are unfinished things here, because it's WIP, let's finish all features before creating the PR to develop. You can also cherry pick some finished changes and create a PR with that if you want, like changes in the router dependency or in the database/models, as long as the existing functionality keeps working. |
emi420
requested changes
Mar 16, 2026
Contributor
emi420
left a comment
emi420
left a comment
There was a problem hiding this comment.
Great work @categulario !! There are just a few things to be fixed before approving the PR.
- Live compatibility with new code. This feature is now broken because the map can't be created after changes on endpoints.
- Bug with tags
- Track media files ownership
- Small naming issue and missing translation
Collaborator
Author
|
All things have been reviewed and addresed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few things happen here. All surrounding the idea of saving a map.
GET /mapandPOST /map) and an old one is renamed (GET /map/new). The rename allows for a more restful interface.react-router-domis replaced byreact-router.SaveButtonis renamedDownloadButtonand a newSaveButtonis created.Headercomponent is refactored to receive buttons as children, thus simplifying its logic a lot.MapListpage is created containing the table of maps that the user has created.