Fix bug in INP() that caused Overflow error#32
Open
f-fix wants to merge 2 commits into
Open
Conversation
Return type was actually integer, but not marked that way and it caused `Overlow`.
f-fix
added a commit
to f-fix/openMSX
that referenced
this pull request
Jul 7, 2026
…e older versions to reduce confusion. This version newly incorporates the `BACONLDR.BIN` loader+runtime library for the (MIT-licensed) [MSX-BACON](https://github.com/hra1129/msx_basic_compiler) BASIC compiler, which is used to build a precompiled version of the test suite. This precompiled version loads and runs quite a bit faster on machines with disks and sufficient RAM (64K or more). This precompiled version of the test suite is assembled using [zma](https://github.com/hra1129/zma). To rebuild the precompiled test suite requires an MSX-BACON compiler bugfix from hra1129/msx_basic_compiler#32 to make `INP(`...`)` usable. Prebuilt binaries are included to ease testing on real hardware. A small, standalone public domain Python CAS-to-WAV converter generated by Google's Gemini search assistant is also included, and was used to generate the WAV version of the cassette test suite from the CAS image. The cassette version of the test suite excludes the precompiled MSX-BACON version as it would complicate cassette loading. The X-BASIC / BASIC'n / MSXべーしっ君 `_TURBO` compiler is still recommended when loading from cassette, and for loading from disk in machines with 32KB of Z80 RAM. Machines with only 16KB of Z80 RAM are stuck with slow interpreted MSX-BASIC. 8KB of Z80 RAM isn't enough to run these tests.
f-fix
added a commit
to f-fix/openMSX
that referenced
this pull request
Jul 7, 2026
… older versions to reduce confusion. This version newly incorporates the `BACONLDR.BIN` loader+runtime library for the (MIT-licensed) [MSX-BACON](https://github.com/hra1129/msx_basic_compiler) BASIC compiler, which is used to build a precompiled version of the test suite. This precompiled version loads and runs quite a bit faster on machines with disks and sufficient RAM (64K or more). This precompiled version of the test suite is assembled using [zma](https://github.com/hra1129/zma). To rebuild the precompiled test suite requires an MSX-BACON compiler bugfix from hra1129/msx_basic_compiler#32 to make `INP(`...`)` usable. Prebuilt binaries are included to ease testing on real hardware. A small, standalone public domain Python CAS-to-WAV converter generated by Google's Gemini search assistant is also included, and was used to generate the WAV version of the cassette test suite from the CAS image. The cassette version of the test suite excludes the precompiled MSX-BACON version as it would complicate cassette loading. The X-BASIC / BASIC'n / MSXべーしっ君 `_TURBO` compiler is still recommended when loading from cassette, and for loading from disk in machines with 32KB of Z80 RAM. Machines with only 16KB of Z80 RAM are stuck with slow interpreted MSX-BASIC. 8KB of Z80 RAM isn't enough to run these tests. This is related to openMSX#2138
MBilderbeek
pushed a commit
to openMSX/openMSX
that referenced
this pull request
Jul 9, 2026
… older versions to reduce confusion. This version newly incorporates the `BACONLDR.BIN` loader+runtime library for the (MIT-licensed) [MSX-BACON](https://github.com/hra1129/msx_basic_compiler) BASIC compiler, which is used to build a precompiled version of the test suite. This precompiled version loads and runs quite a bit faster on machines with disks and sufficient RAM (64K or more). This precompiled version of the test suite is assembled using [zma](https://github.com/hra1129/zma). To rebuild the precompiled test suite requires an MSX-BACON compiler bugfix from hra1129/msx_basic_compiler#32 to make `INP(`...`)` usable. Prebuilt binaries are included to ease testing on real hardware. A small, standalone public domain Python CAS-to-WAV converter generated by Google's Gemini search assistant is also included, and was used to generate the WAV version of the cassette test suite from the CAS image. The cassette version of the test suite excludes the precompiled MSX-BACON version as it would complicate cassette loading. The X-BASIC / BASIC'n / MSXべーしっ君 `_TURBO` compiler is still recommended when loading from cassette, and for loading from disk in machines with 32KB of Z80 RAM. Machines with only 16KB of Z80 RAM are stuck with slow interpreted MSX-BASIC. 8KB of Z80 RAM isn't enough to run these tests. This is related to #2138
uniskie
added a commit
to uniskie/openMSX
that referenced
this pull request
Jul 11, 2026
commit 5dd2873 Author: f-fix <bsittler@iname.com> Date: Wed Jul 8 20:51:54 2026 -0700 Simplify rebuild and add 2400bps WAV. Also fix a typo in the .md. commit bd8e775 Author: f-fix <bsittler@iname.com> Date: Tue Jul 7 12:10:19 2026 -0700 Update the I/O port Kanji/Hangul/Hanja ROM tests to v3.1. Also remove older versions to reduce confusion. This version newly incorporates the `BACONLDR.BIN` loader+runtime library for the (MIT-licensed) [MSX-BACON](https://github.com/hra1129/msx_basic_compiler) BASIC compiler, which is used to build a precompiled version of the test suite. This precompiled version loads and runs quite a bit faster on machines with disks and sufficient RAM (64K or more). This precompiled version of the test suite is assembled using [zma](https://github.com/hra1129/zma). To rebuild the precompiled test suite requires an MSX-BACON compiler bugfix from hra1129/msx_basic_compiler#32 to make `INP(`...`)` usable. Prebuilt binaries are included to ease testing on real hardware. A small, standalone public domain Python CAS-to-WAV converter generated by Google's Gemini search assistant is also included, and was used to generate the WAV version of the cassette test suite from the CAS image. The cassette version of the test suite excludes the precompiled MSX-BACON version as it would complicate cassette loading. The X-BASIC / BASIC'n / MSXべーしっ君 `_TURBO` compiler is still recommended when loading from cassette, and for loading from disk in machines with 32KB of Z80 RAM. Machines with only 16KB of Z80 RAM are stuck with slow interpreted MSX-BASIC. 8KB of Z80 RAM isn't enough to run these tests. This is related to openMSX#2138 commit 415afab Author: Manuel Bilderbeek <Manuel.Bilderbeek@gmail.com> Date: Thu Jul 9 00:23:23 2026 +0200 Remove some noisy constuctor calls... Tiny improvement on previous commit. More lines, but overall cleaner... commit 8dde720 Author: Manuel Bilderbeek <Manuel.Bilderbeek@gmail.com> Date: Wed Jul 8 23:47:12 2026 +0200 Add note in debugger help texts about adress from symbol. Due to incomplete constexpr support for std::string in the current C++ code I need to through some hoops here (thanks to Gemini) to get this constexpr. But I think I made it. If someone has a better idea on how to solve this, please change the code :) Fixes openMSX#2149. commit aa76d74 Author: -ffix <164929254+f-fix@users.noreply.github.com> Date: Tue Jul 7 10:41:39 2026 -0700 I/O port Kanji behavior of Sony HB-11 confirmed by hw test (openMSX#2146) A Hit Bit U owner has run the test and provided me with screen photos that show this behavior. Co-authored-by: Benjamin C. Wiley Sittler <bsittler@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The result of
INP(...)is an integer, but it was not setting the expression type correctly soFRCINTwas called with wrong values and caused anOverflowerror.Fixes #33