Skip to content

feat(edit_table): 添加列分隔线以增强单元格边界区分 #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
htmambo wants to merge 1 commit into from
Closed

feat(edit_table): 添加列分隔线以增强单元格边界区分 #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions crates/one_ui/src/edit_table/state.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ use gpui_component::{
};

const SCROLLBAR_WIDTH: Pixels = px(16.);
const COLUMN_SEPARATOR_WIDTH: Pixels = px(1.);
Comment on lines 25 to +26

gpui::actions!(
edit_table_internal,
Expand Down Expand Up @@ -1938,14 +1939,27 @@ where

let is_single_select_active =
(is_active_cell || is_select_cell) && !is_editing && !is_multi_selection;
let show_column_separator = !is_editing && !border_right && !is_single_select_active;

let mut cell = div()
.id(cell_id)
.w(col_width)
.h_full()
.relative()
.flex_shrink_0()
.overflow_hidden()
.whitespace_nowrap()
.when(show_column_separator, |this| {
this.child(
div()
.absolute()
.top_0()
.right_0()
.bottom_0()
.w(COLUMN_SEPARATOR_WIDTH)
.bg(cx.theme().border),
)
})
// 选区内的所有单元格使用背景色
.when(is_in_selection && !is_editing, |this| {
this.bg(cx.theme().table_active)
Expand Down