feat(feed-directory): last_result demotion and fail-closed catalog v2 - #1250
Merged
Conversation
Support catalog_version 2 only with required last_result; demote empty/error in sort, show ambient indicators, and warn before subscribe on failing rows.
Clarify that Feed Directory scrape hints are instance last-known signals; cold instances show no badge and this is not /health.
Align bulk export with subscribe warnings and drop "ready-to-use" when the catalog can include empty/error last scrapes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
catalog_version2 only; requirelast_resulton each catalog row (catalog-api.ts,types.ts).empty/errorrows in default sort; ambient last-scrape chrome in the browse UI (filters.ts,last-result.ts,render.ts, CSS).7c94edc./health(use-the-feed-directory.mdx,CONTEXT.md).Why
Live browse depends on html2rss-web catalog API v2 exposing per-config
last_result. Without fail-closed parsing and UI demotion, cold or failing scrapes look as healthy as successful ones, and bulk OPML/copy overstated readiness.Risk
Review map
src/components/feed-directory/adapters/catalog-api.ts— fail-closed v2 + requiredlast_resultsrc/components/feed-directory/domain/last-result.ts+filters.ts— demotion / failing helperssrc/components/feed-directory/ui/render.ts+app/FeedDirectoryApp.ts— chrome, subscribe/copy/OPML warn paths*.test.ts— contract coverage for parse, sort, warn copyValidation
make checkmake build