Skip to content

desktop: add trailing semicolon to Keywords and expand keyword list - #2028

Merged
BenBE merged 1 commit into
htop-dev:mainfrom
add-uos:main
Jun 24, 2026
Merged

desktop: add trailing semicolon to Keywords and expand keyword list#2028
BenBE merged 1 commit into
htop-dev:mainfrom
add-uos:main

Conversation

@add-uos

@add-uos add-uos commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Add 'resources', 'monitoring', 'performance' keywords to improve discoverability in desktop search. Also add trailing semicolon for consistency with the Categories style in the same file.

Ref: https://specifications.freedesktop.org/desktop-entry/1.0/value-types.html
Ref: https://specifications.freedesktop.org/desktop-entry/latest/value-types.html
Ref: https://specifications.freedesktop.org/desktop-entry/latest/recognized-keys.html

@coderabbitai

coderabbitai Bot commented Jun 22, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 3a37497f-62fd-4998-9b58-4ffa36c6a0b9

📥 Commits

Reviewing files that changed from the base of the PR and between 89eaede and bcbebfe.

📒 Files selected for processing (1)
  • htop.desktop

📝 Walkthrough

Walkthrough

The Keywords field in htop.desktop is expanded from system;process;task to system;process;task;resources;monitoring;performance;, adding three keywords that better describe htop's functionality. The trailing semicolon is included to comply with the XDG Desktop Entry specification requirement that semicolon-separated list values be terminated with a delimiter.

Poem

Three keywords join the list today,
Resources, monitoring lead the way.
Performance follows, keywords grow.
A trailing semicolon seals the flow.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@BenBE BenBE added documentation 📖 Improvements or additions to documentation enhancement Extension or improvement to existing feature distro issue Issue caused by distribution packaging or libraries buggy on a specific distribution labels Jun 22, 2026
@BenBE

BenBE commented Jun 22, 2026

Copy link
Copy Markdown
Member

I think while addressing this, we also could add some related tags like resources and monitoring. Any others that might be worth including?

Also, from the linked docs, the trailing ; is marked as SHOULD (only if no keywords are present, a single ; is marked as MUST).

@add-uos

add-uos commented Jun 23, 2026

Copy link
Copy Markdown
Contributor Author

@BenBE Thank you for the feedback! I agree that expanding the keywords would be helpful for discoverability. I'd like to propose adding resources, monitoring, and performance, so it would become:

Keywords=system;process;task;resources;monitoring;performance;

Regarding the trailing semicolon — while the latest spec marks it as SHOULD, I thought it would be nice to keep it consistent with the existing Categories style in the same file, which already uses a trailing semicolon. That said, if removing the trailing semicolon is preferred for alignment with the latest spec, I'm fine with that too!

@BenBE

BenBE commented Jun 23, 2026

Copy link
Copy Markdown
Member

Those additions sound reasonable. Just wanted to avoid changing that file just to add a semicolon that's optional. ;-)

Can you update the PR by amending its commit to include these additional keywords?

@BenBE BenBE added this to the 3.6.0 milestone Jun 23, 2026
Add 'resources', 'monitoring', 'performance' keywords to improve
discoverability in desktop search. Also add trailing semicolon for
consistency with the Categories style in the same file.

Ref: https://specifications.freedesktop.org/desktop-entry/1.0/value-types.html
Ref: https://specifications.freedesktop.org/desktop-entry/latest/value-types.html
Ref: https://specifications.freedesktop.org/desktop-entry/latest/recognized-keys.html
@add-uos

add-uos commented Jun 24, 2026

Copy link
Copy Markdown
Contributor Author

Okay, I'll update it right away.

@add-uos add-uos changed the title desktop: add trailing semicolon to Keywords desktop: add trailing semicolon to Keywords and expand keyword list Jun 24, 2026
@BenBE
BenBE merged commit f137d5a into htop-dev:main Jun 24, 2026
21 checks passed
@BenBE BenBE modified the milestones: 3.6.0, 3.5.2 Jul 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

distro issue Issue caused by distribution packaging or libraries buggy on a specific distribution documentation 📖 Improvements or additions to documentation enhancement Extension or improvement to existing feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants