desktop: add trailing semicolon to Keywords and expand keyword list - #2028
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
I think while addressing this, we also could add some related tags like Also, from the linked docs, the trailing |
|
@BenBE Thank you for the feedback! I agree that expanding the keywords would be helpful for discoverability. I'd like to propose adding resources, monitoring, and performance, so it would become:
Regarding the trailing semicolon — while the latest spec marks it as SHOULD, I thought it would be nice to keep it consistent with the existing Categories style in the same file, which already uses a trailing semicolon. That said, if removing the trailing semicolon is preferred for alignment with the latest spec, I'm fine with that too! |
|
Those additions sound reasonable. Just wanted to avoid changing that file just to add a semicolon that's optional. ;-) Can you update the PR by amending its commit to include these additional keywords? |
Add 'resources', 'monitoring', 'performance' keywords to improve discoverability in desktop search. Also add trailing semicolon for consistency with the Categories style in the same file. Ref: https://specifications.freedesktop.org/desktop-entry/1.0/value-types.html Ref: https://specifications.freedesktop.org/desktop-entry/latest/value-types.html Ref: https://specifications.freedesktop.org/desktop-entry/latest/recognized-keys.html
|
Okay, I'll update it right away. |
Add 'resources', 'monitoring', 'performance' keywords to improve discoverability in desktop search. Also add trailing semicolon for consistency with the Categories style in the same file.
Ref: https://specifications.freedesktop.org/desktop-entry/1.0/value-types.html
Ref: https://specifications.freedesktop.org/desktop-entry/latest/value-types.html
Ref: https://specifications.freedesktop.org/desktop-entry/latest/recognized-keys.html