exit follow mode when search or filter is cancelled - #2050
Conversation
condition change in bbec22d caused panel state during search to persist even if the search was cancelled (e.g. escape key). previous behaviour relied on the absence of the `HTOP_KEEP_FOLLOWING` reaction to stop following, which is no longer the case.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthrough
Suggested reviewers: Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Hm, do we want that? Do we want to guard it with the |
|
The behaviour I would expect is not to follow unless there is either a search match, or the search has been confirmed (e.g. pressing Enter). At the very least cancelling a failed search shouldn't keep following whatever was selected by it, probably in error. in regard to I also feel the current behaviour contradicts the intended behaviour of 7d7baeb: a process being followed when confirmed in the search. Currently, every search match, failed or not, will be followed whether the search was confirmed or aborted. |
condition change in bbec22d caused panel state during search to persist after the search was cancelled (e.g. escape key). previous behaviour relied on the absence of the
HTOP_KEEP_FOLLOWINGreaction to stop following, which is no longer the case.explicitly setting
host->activeTable->followingto-1now, has the same effect as not settingHTOP_KEEP_FOLLOWINGdid before bbec22d.